-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/14/2014 02:42 AM, Lukas Slebodnik wrote:
ehlo,
release blocked by:
https://lists.fedorahosted.org/pipermail/sssd-devel/2014-April/019043.html
Two patches are attachd.
My notes: basicobject no ABI change new function added
simplebuffer_get_vbuf libref_array no ABI change function
ref_array_debug added to public header ref_array.h
libcollection version-info should be 4:0:0, but there would be big
jump in soname libcollection.so.2.1.0 -> libcollection.so.4.0.0
-function removed from ABI: col_allocate_item (declared in
collection_priv.h)
libini_config version-info should be 5:0:0, but there would be big
jump in soname libini_config.so.3.1.0 -> libini_config.so.5.0.0
-functions removed from ABI:collect_metadata, empty_section,
ini_boundary_cb, ini_cleanup_cb, ini_comment_cb,
ini_get_error_str,is_allowed_spaces. is_just_spaces, parser_run,
prepare_metadata, print_grammar_errors, print_validation_errors,
read_line, valid_collision_flags //were declared in internal
ini_metadata.h or ini_config_priv.h
Patch 0001:
libpath_utils: ack
libdhash: ack
libcollection: I had a discussion with Lukas on IRC about this. This
was a premature optimization. We should follow the version-info update
rules here, regardless of the jump in soname to so.4. The reason for
this is that the meaning of the previous 2.1.0 version was this: "This
library can support clients that are talking version 2 of the ABI as
well as version 3 (the second value is the number of additional
interface revisions beyond it).
However, when we created ABI version 4, we *removed* some functions.
This means we are no longer capable of meeting the needs of clients
expecting versions 2 and 3, so we have to set the minimum version to 4
and re-set the second value to zero (for future use if we add an ABI
version 5). In theory, we could someday go from 4.99.0 directly to
103.0.0, which would be a much larger jump and it would still be a
*correct* answer.
So the correct version-info here is 4:0:0
Also, I'm not familiar enough with symbol table files. Why are you
moving col_destroy_collection_with_cb out of a separate section in the
symbol table? Shouldn't they remain distinct for historical reasons?
Maybe I just don't understand this area enough.
ini_config: we need to be using 5:0:0 for version-info.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iEYEARECAAYFAlNrj/kACgkQeiVVYja6o6PsKACgqV+5YC1CsCDQvy2KJ8ebg6g4
1hwAn0XOgswZvRMbRhWeRZ1j7GwiA5QV
=XDoi
-----END PGP SIGNATURE-----