-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/10/2009 02:29 PM, Jakub Hrozek wrote:
On 12/10/2009 06:46 PM, Stephen Gallagher wrote:
> ********* *BEGIN ENCRYPTED or SIGNED PART* *********
> On 12/09/2009 07:08 PM, Jakub Hrozek wrote:
>>> There were two functions for parsing strings by a separator. This patch
>>> consolidates on the one previously used in confdb. This also allows
>>> stripping the tokens of whitespace.
>>>
>>> Fixes: #319
> Nack.
Revised patch attached
Nack.
In sdap_service_init, you removed the need for the count variable.
Remove it and use NULL instead of &count in the split_on_separator() call
Fix this last nitpick and I'll ack.
Thanks.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkshUhIACgkQeiVVYja6o6OZSgCeKvfN0eQlDFohD1Sj41Yb1THd
ecwAnjkFxturiTiZ45rpGAoKf3HEibaI
=oQPE
-----END PGP SIGNATURE-----