On (25/04/14 11:42), Jakub Hrozek wrote:
On Wed, Apr 23, 2014 at 11:28:51AM -0400, Simo Sorce wrote:
On Wed, 2014-04-23 at 17:12 +0200, Jakub Hrozek wrote:
OK, new patches that use ':' as a separator are attached. This version uses key:value, but that can be swapped.
Why do you consider the 'key' to be the remote attribute name ? I can't make sense of it :-)
The "key" sssd looks for in it's cache is the sysdb name, no ?
Simo.
I don't really mind too much and appears Jan does not either. So I simply swapped the order in the attached patches, now it's sysdb:LDAP.
Man page was changed accordingly.
Jan, could you check if the man page change (src/man/sssd-ldap.5.xml in the second patch) reads good to you?
From 92acd3f95ef5ae8ce49f398f9ef616a79887193f Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Mon, 21 Apr 2014 21:33:36 +0200 Subject: [PATCH 1/3] LDAP: Fix off-by-one bug in sdap_copy_opts
The sdap_copy_opts function copied all the arguments except for the sentinel.
Makefile.am | 3 +++ src/providers/ldap/sdap.c | 5 +++- src/tests/ipa_ldap_opt-tests.c | 55 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 62 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am index 5dc359596416f1202c5bbf5cc2585b60eeeea6f1..56d8e1df648822a1fe8b3ca5fc8995f3c78a8566 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1215,6 +1215,9 @@ auth_tests_LDADD = \
ipa_ldap_opt_tests_SOURCES = \ src/providers/data_provider_opts.c \
- src/providers/ldap/sdap.c \
- src/providers/ldap/sdap_range.c \
- src/util/sss_ldap.c \ src/tests/ipa_ldap_opt-tests.c
ipa_ldap_opt_tests_CFLAGS = \ $(AM_CFLAGS) \
I appologize for late response. I didn't have a time to review this patch. This simple change causes probelm with linking this test on systems with disabled link_all_deplibs (debian)
Attached patch fix this issue.
LS