On (29/06/16 11:28), Jakub Hrozek wrote:
On Tue, Jun 28, 2016 at 05:50:15PM +0200, Jakub Hrozek wrote:
> On Tue, Jun 28, 2016 at 12:45:13PM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > @see commit message in attached patch.
> >
> > LS
>
> Thanks, the code reads much better and works on RHEL-6 and Fedora. I'm
> waiting for CI before pushing. But in the meantime, ACK.
I would like to ask for a small modification:
diff --git a/src/external/systemd.m4 b/src/external/systemd.m4
index f2aeda1..3be8d27 100644
--- a/src/external/systemd.m4
+++ b/src/external/systemd.m4
@@ -6,9 +6,10 @@ PKG_CHECK_EXISTS([systemd],
dnl Libraries libsystemd-journal and libsystem-login are deprecarted
dnl since systemd 209 and are removed in systemd 230. The library libsystemd
dnl is replacement of libsystemd-{login,journal,daemon,id128} libraries
-PKG_CHECK_EXISTS([libsystemd],
- [HAVE_LIBSYSTEMD=yes],
- [HAVE_LIBSYSTEMD=no])
+PKG_CHECK_MODULES([SYSTEMD],
+ [libsystemd],
+ [HAVE_LIBSYSTEMD=yes],
+ [HAVE_LIBSYSTEMD=no])
AS_IF([test x$HAVE_LIBSYSTEMD = xyes],
[login_lib_name=libsystemd],
The reason is that Simo's secret provider patchset includes the
infrastructure to socket-activate responders, which means all responders
(through responder_common.c) will link to libsystemd if available. So I
need to know SYSTEMD_LIBS in the Makefile.
As you might see in the file, the library
libsystemd was introduced in
systemd 209. Which function are required for secret provider?
Because if they are availale in systemd < 209 then qe might try
to do the same as with (libsystemd.so vs libsystemd-journal.so)
Or we can ignore all distributions with systemd < 209 and drop
workarounds for libsystemd-journal.so and libsystemd-logind.so
LS