URL: https://github.com/SSSD/sssd/pull/175 Author: lslebodn Title: #175: Add module for starting services Action: opened
PR body: """ This is a WIP version of reducing code duplication in our cwrap integration tests.
I am still not sure whether we should also reuse function `create_sssd_fixture`. And if yes; then probably in different nodule then `services`
And comments are welcome.
BTW I wrote patches few weeks ago; therefore new tests are not converted. I am just sending patches to get some feedback.
Site effect of this patches is that tests are cca 20% faster (IIRC) """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/175/head:pr175 git checkout pr175
URL: https://github.com/SSSD/sssd/pull/175 Title: #175: Add module for starting services
jhrozek commented: """ I think this is a really nice refactor. I also think that the LDAP server could be another service, but I'm not sure if we want to mix all services in a single file. Would it make more sense to create a services/ package and add sssd.py, openldap.py, krb5.py (this is from KCM) there? Maybe some code could be shared between the services like spawning a generic program and killing it later pased on its PID.
About the fixture, I would definitely split it out to a module as well, but I think moving it to fixtures.py (a new file) would make more sense. """
See the full comment at https://github.com/SSSD/sssd/pull/175#issuecomment-284662995
URL: https://github.com/SSSD/sssd/pull/175 Title: #175: Add module for starting services
fidencio commented: """ I'm adding "Changes requested" label by @jhrozek's review. """
See the full comment at https://github.com/SSSD/sssd/pull/175#issuecomment-298602789
URL: https://github.com/SSSD/sssd/pull/175 Title: #175: Add module for starting services
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/175 Title: #175: Add module for starting services
Label: +Deferred
URL: https://github.com/SSSD/sssd/pull/175 Author: lslebodn Title: #175: Add module for starting services Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/175/head:pr175 git checkout pr175
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
andreboscatto
-
fidencio
-
jhrozek
-
lslebodn