[sssd PR#208][opened] IFP: Filter with * in Users.ListByName method
by celestian
URL: https://github.com/SSSD/sssd/pull/208
Author: celestian
Title: #208: IFP: Filter with * in Users.ListByName method
Action: opened
PR body:
"""
This patch fixed asterisk in filter of Users.ListByName method.
Resolves:
https://pagure.io/SSSD/sssd/issue/3305
How to test
```
# We have sssd configured and there are some users
# Wee need also ifp service enabled in sssd.conf
# Restart sssd
systemctl daemon-reload
sudo su -c "truncate -s0 /var/log/sssd/*.log"
sudo su -c "rm -f /var/lib/sss/db/*"
sudo su -c "rm -f /var/lib/sss/mc/*"
sudo systemctl restart sssd.service
sudo su -c "truncate -s0 /var/log/sssd/*.log"
# It will return users (without patch, it will crash).
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Users \
org.freedesktop.sssd.infopipe.Users.ListByName \
string:"*" uint32:"100"
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/208/head:pr208
git checkout pr208
6 years, 9 months
Using labels under https://github.com/SSSD/sssd/pulls
by Amit
Dear Devels,
It looks at present we only use Reviews-tab in SSSD repo to set {Changes
requested ..only}. We can set 'Review required' + other labels as well
How about Setting Labels onto the PR? We can add these Labels:
- Bug Fix, cleanups, common, documentation, feature, needs-qa ....
other maybe..
--
Thanks
Amit Kumar
!!If you stumble, get back up.
What happened yesterday, no longer matters.
Today is another day to move closer to your GOAL!!
6 years, 9 months
[sssd PR#339][opened] UTIL: Create custom abort function for talloc_get_type_abort()
by amitkumar50
URL: https://github.com/SSSD/sssd/pull/339
Author: amitkumar50
Title: #339: UTIL: Create custom abort function for talloc_get_type_abort()
Action: opened
PR body:
"""
Bug is about replacing talloc_get_type() with talloc_get_type_abort(const void *ptr,#type). talloc_get_type_abort() is type safe equivalent of talloc_get_type(). talloc_get_type_abort() calls abort() function is case of type mismatch.
How it will work:
a. Defining a custom abort function sss_talloc_abort(const char *reason) in src/util/util.c.
b. Setting this custom abort function using void talloc_set_abort_fn(void (abort_fn)(const char reason)) => talloc_set_abort_fn(sss_talloc_abort);
c. Replacing all occurances of talloc_get_type() with talloc_get_type_abort();
About the Change:
Change will comprise of 3 patches
Patch-1(This Patch): Introduces the new sss_talloc_abort() function, which will be setted as custom abort function by passing to talloc_set_abort_fn().
Patch-2: When changes are finalized, custom abort function's contents are finalized. This patch will enable custom abort function wherever required.
Patch-3: When above two patches goes well. This will change all occurences of talloc_get_type() to talloc_get_type_abort().
Resolves: https://pagure.io/SSSD/sssd/issue/1149
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/339/head:pr339
git checkout pr339
6 years, 9 months