[sssd PR#328][opened] KRB5: Return invalid credentials internally when attempting to renew an expired TGT
by jhrozek
URL: https://github.com/SSSD/sssd/pull/328
Author: jhrozek
Title: #328: KRB5: Return invalid credentials internally when attempting to renew an expired TGT
Action: opened
PR body:
"""
Since 1.14.2 and in particular commit
d3348f49260998880bb7cd3b2fb72d562b1b7a64 we return ERR_NETWORK_IO for any
krb5_child operations that receive KRB5KRB_AP_ERR_TKT_EXPIRED from libkrb5.
However, when the action that krb5_child performs is ticket renewal and the
ticket is totally expired, this can send the SSSD into offline mode.
Instead, this patch converts the KRB5KRB_AP_ERR_TKT_EXPIRED code into
sssd-internal ERR_CREDS_EXPIRED which map_krb5_error() won't map anymore.
The effect on the deamon is that just the single renewal fails, but the
failover code is not called and therefore sssd doesn't switch into offline
mode.
Resolves: https://pagure.io/SSSD/sssd/issue/3406
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/328/head:pr328
git checkout pr328
6 years, 8 months
[sssd PR#327][opened] RESPONDERS: Fix terminating idle connections
by jhrozek
URL: https://github.com/SSSD/sssd/pull/327
Author: jhrozek
Title: #327: RESPONDERS: Fix terminating idle connections
Action: opened
PR body:
"""
The client_idle_handler() function tried to schedule another tevent timer
to check for idle client connections in case the current connection was
still valid, but in doing so, it also stored the current time into the
last_request_time field of the client context.
This kept the connection always alive, because the last_request_time could
then never be older than the timeout.
This patch changes the setup_client_idle_timer() function to only do what
the synopsis says and set the idle timer. The caller (usually the function
that accepts the connection) is supposed to store the request time itself.
To test, revert the patch with the code fix and run the integration test
in the other patch.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/327/head:pr327
git checkout pr327
6 years, 8 months