URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
Okay, let me know when you update the patches and I'll do a third round of review then.
@jhrozek, I'd suggest you to wait with the downstream tests till we have the ACK from Scott.
"""
See the full comment at https://github.com/SSSD/sssd/pull/433#issuecomment-342405399
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
sumit-bose commented:
"""
Hi Fabiano,
thank you for the review. Scott's test are not done yet. He found that just showing the subject-DN to select a certificate is not sufficient for some types of Smartcards where all certificates will have the same subject-DN. I prepared a new build for him which he hopefully can test today.
"""
See the full comment at https://github.com/SSSD/sssd/pull/433#issuecomment-342404235
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
After a few tries to run coverity in the new code I've finally able to and seems that no new issues have been introduced.
You have an ACK from me. @jhrozek would like to run some downstream tests (please, @jhrozek, let us know about the result as soon as you have those) and after that and Scott ACK this PR will be ready to go.
@sumit-bose, please, let us know about Scott's tests results.
"""
See the full comment at https://github.com/SSSD/sssd/pull/433#issuecomment-342402598