[sssd PR#433][comment] PAM: Multiple certificates on a Smartcard
by fidencio
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
Okay, Debian testing has been failing on our CI and the following patch solves the issue:
```
[ffidenci@pessoa sssd]$ cat 0001-fixup-PAM-handled-multiple-certs-in-the-responder.patch
From 0ce79d843545cb939b891cdf66b1dbc8133972a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio(a)redhat.com>
Date: Wed, 8 Nov 2017 15:47:01 +0100
Subject: [PATCH] fixup! PAM: handled multiple certs in the responder
---
Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 5296c4ca0..57e03abfe 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1401,6 +1401,7 @@ sssd_pam_LDADD = \
$(PAM_LIBS) \
$(SYSTEMD_DAEMON_LIBS) \
$(SSSD_INTERNAL_LTLIBS) \
+ libsss_certmap.la \
$(NULL)
if BUILD_SUDO
@@ -2423,6 +2424,7 @@ pam_srv_tests_LDADD = \
$(SYSTEMD_DAEMON_LIBS) \
libsss_test_common.la \
libsss_idmap.la \
+ libsss_certmap.la \
$(NULL)
EXTRA_responder_get_domains_tests_DEPENDENCIES = \
--
2.13.6
```
You can find the two patches that I mentioned at: https://github.com/fidencio/sssd/tree/review/multiple_certs
"""
See the full comment at https://github.com/SSSD/sssd/pull/433#issuecomment-342841614
6 years, 5 months
[sssd PR#433][comment] PAM: Multiple certificates on a Smartcard
by fidencio
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
Hmm. It should be enough:
```
[ffidenci@pessoa x86_64]$ cat 0001-fixup-pam_sss-refactoring-use-struct-cert_auth_info.patch
From 18286c3ffd14053909eca1114419c3a63009e9dd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio(a)redhat.com>
Date: Wed, 8 Nov 2017 14:30:25 +0100
Subject: [PATCH] fixup! pam_sss: refactoring, use struct cert_auth_info
---
contrib/sssd.spec.in | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index b3ebd32cd..4a2745baa 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -121,6 +121,12 @@
%global with_kcm_option --without-kcm
%endif
+%if (0%{?fedora} >= 27 || (0%{?rhel} >= 7 && 0%{?rhel7_minor} > 4))
+ %global depend_on_gdm_devel 1
+%else
+ %global depend_on_gdm_devel 0
+%endif
+
Name: @PACKAGE_NAME@
Version: @PACKAGE_VERSION@
Release: 0@PRERELEASE_VERSION@%{?dist}
@@ -233,7 +239,9 @@ BuildRequires: libuuid-devel
BuildRequires: jansson-devel
BuildRequires: libcurl-devel
%endif
+%if (0%{?depend_on_gdm_devel} == 1)
BuildRequires: gdm-devel
+%endif
%description
Provides a set of daemons to manage access to remote directories and
--
2.13.6
```
Just fired an internal CI build in order to have it tested.
"""
See the full comment at https://github.com/SSSD/sssd/pull/433#issuecomment-342818014
6 years, 5 months
[sssd PR#433][comment] PAM: Multiple certificates on a Smartcard
by fidencio
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
Hmm. It should be enough:
```
[ffidenci@pessoa x86_64]$ cat 0001-fixup-pam_sss-refactoring-use-struct-cert_auth_info.patch
From 18286c3ffd14053909eca1114419c3a63009e9dd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio(a)redhat.com>
Date: Wed, 8 Nov 2017 14:30:25 +0100
Subject: [PATCH] fixup! pam_sss: refactoring, use struct cert_auth_info
---
contrib/sssd.spec.in | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index b3ebd32cd..4a2745baa 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -121,6 +121,12 @@
%global with_kcm_option --without-kcm
%endif
+%if (0%{?fedora} >= 27 || (0%?{?rehl} >= 7 && 0%{rhel7_minor} > 4))
+ %global depend_on_gdm_devel 1
+%else
+ %global depend_on_gdm_devel 0
+%endif
+
Name: @PACKAGE_NAME@
Version: @PACKAGE_VERSION@
Release: 0@PRERELEASE_VERSION@%{?dist}
@@ -233,7 +239,9 @@ BuildRequires: libuuid-devel
BuildRequires: jansson-devel
BuildRequires: libcurl-devel
%endif
+%if (0%{?depend_on_gdm_devel} == 1)
BuildRequires: gdm-devel
+%endif
%description
Provides a set of daemons to manage access to remote directories and
--
2.13.6
```
Just fired an internal CI build in order to have it tested.
"""
See the full comment at https://github.com/SSSD/sssd/pull/433#issuecomment-342818014
6 years, 5 months