On 08/16/2016 02:05 AM, Lukas Slebodnik wrote:
> On (12/08/16 12:24), Justin Stephenson wrote:
>> Simple error message patch, resolves
>>
https://fedorahosted.org/sssd/ticket/3130
>>
>> Kind regards,
>>
>> Justin Stephenson
>>
> >From 080f9639e120329d069d4f0ba5edcc776e0179c2 Mon Sep 17 00:00:00 2001
>> From: Justin Stephenson <jstephen(a)redhat.com>
>> Date: Fri, 12 Aug 2016 12:12:57 -0400
>> Subject: [PATCH] SSSCTL: More helpful error message when InfoPipe is
>> disabled
>>
>> Resolves:
>>
https://fedorahosted.org/sssd/ticket/3130
>> ---
>> src/tools/sssctl/sssctl_sifp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/tools/sssctl/sssctl_sifp.c
>> b/src/tools/sssctl/sssctl_sifp.c
>> index
>>
e541c4b27ba38e50b209b0957c8b38f03afc891a..d61754c095366d07bae812c38a24a88f07c197f5
>> 100644
>> --- a/src/tools/sssctl/sssctl_sifp.c
>> +++ b/src/tools/sssctl/sssctl_sifp.c
>> @@ -25,8 +25,8 @@
>> #include "util/util.h"
>> #include "tools/sssctl/sssctl.h"
>>
>> -#define ERR_SSSD _("Check that SSSD is running and " \
>> - "the InfoPipe responder is enabled.\n")
>> +#define ERR_SSSD _("IFP Disabled: Please add the ifp service to the
>> service" \
>> + "list in sssd.conf and restart the service.\n")
> Here is a comment from the author of previous message.
> 05:26 < lslebodn> pbrezina: Do you have any coment to the patch
> "SSSCTL: More helpful error message when
> InfoPipe is disabled" ?
> 05:26 < lslebodn> becuase I plan to push it :-)
> 05:28 < pbrezina> lslebodn, I still think that the original message
> is more accurate, but I don't oppose.
>
> I tent to agree.
> I would reserve the original message and wrote a "HINT" in next line.
> Any objection for such compromise?
>
> LS
0001-SSSCTL-More-helpful-error-message-when-InfoPipe-is-d-v2.patch
From 49fd8ff5100f38dbee9b873120b703d2499d09d2 Mon Sep 17 00:00:00 2001
From: Justin Stephenson <jstephen(a)redhat.com>
Date: Fri, 12 Aug 2016 12:12:57 -0400
Subject: [PATCH] SSSCTL: More helpful error message when InfoPipe is
disabled
Resolves:
https://fedorahosted.org/sssd/ticket/3130
---
src/tools/sssctl/sssctl_sifp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/tools/sssctl/sssctl_sifp.c b/src/tools/sssctl/sssctl_sifp.c
index e541c4b27ba38e50b209b0957c8b38f03afc891a..33ba6404effff7d0b8116aa3df6bfefa37a3dd3c
100644
--- a/src/tools/sssctl/sssctl_sifp.c
+++ b/src/tools/sssctl/sssctl_sifp.c
@@ -26,7 +26,9 @@
#include "tools/sssctl/sssctl.h"
#define ERR_SSSD _("Check that SSSD is running and " \
- "the InfoPipe responder is enabled.\n")
+ "the InfoPipe responder is enabled.\n" \
+ "HINT: Add ifp to the services list " \
+ "in sssd.conf and restart sssd.\n")
struct sssctl_sifp_data {
sss_sifp_ctx *sifp;
-- 2.7.4