On Sun, Feb 26, 2012 at 07:53:56PM -0500, Stephen Gallagher wrote:
> On Sat, 2012-02-25 at 20:40 +0100, Jakub Hrozek wrote:
> > On Thu, Feb 23, 2012 at 04:12:17PM -0500, Stephen Gallagher wrote:
> > > On Thu, 2012-02-23 at 10:56 +0100, Jakub Hrozek wrote:
> > > > On Wed, Feb 22, 2012 at 03:55:28PM -0500, Stephen Gallagher wrote:
> > > > > We will now use the autodetected location if available, or else
> > > > > fall back to a value provided by --with-nscd in configure and
> > > > > finally resort to a hard-coded default of /usr/sbin/nscd.
> > > > >
> > > > > Fixes
https://fedorahosted.org/sssd/ticket/1129
> > > >
> > > > This doesn't seem to work well with no nscd installed..configure
still
> > > > states "checking for nscd... yes" and NSCD_PATH is still
#defined to
> > > > "/usr/sbin/nscd" even though the file does not exist.
> > >
> > > It was actually harmless, but I changed it so the configure message is
> > > more clear.
> >
> > Sorry, I wasn't clear enough, but that was not my point. The issue here
> > is that even on a system with no nscd installed, both NSCD_PATH and
> > HAVE_NSCD are set. That results into flush_nscd_cache() trying to call
> > the default "/usr/sbin/nscd" binary and failing.
>
> I think you misunderstood the goal of this patch. That's actually
> intentional :)
>
> The code to call the nscd binary is already designed to handle failure
> to call nscd gracefully (this is because there is no hard dependency on
> nscd in the sssd-tools subpackage). The existing situation was requiring
> that nscd be installed at build time so that we could identify where
> nscd would be on an installed system *if nscd was also installed*. So if
> it's in that location, we'll use it. Otherwise we'll ignore the failure
> and move on.
>
> The goal of this patch was only to eliminate the need for having nscd
> installed during build. We'll auto-detect NSCD if it's available,
> otherwise we'll can use a reasonable default or specify the correct path
> by --with-nscd.
You're right, I misunderstood. Ack!