On Wed, May 10, 2017 at 04:13:28PM -0400, Justin Stephenson wrote:
On 05/10/2017 04:12 AM, Jakub Hrozek wrote:
> On Tue, May 09, 2017 at 09:36:45AM -0400, Justin Stephenson wrote:
> > Hello, I wanted to check if anyone has objections or concerns with moving
> > existing code for sss_cache and sss_debuglevel into sssctl for ticket #3057
> > - Merge existing command line tools into sssctl.
> > The deprecated tools will become shell wrappers to the sssctl commands
> > implementing the same functionality so I think it should be transparent to
> > the end-user.
> I'm fine with this.
> The only thing I'm not sure about is documentation. Both sss_cache and
> sss_debuglevel have documentation, but sssctl only has the minimal (on
> purpose) man page.
> But I think it should at least be possible to move the manpage
> (with proper adjustments so that it no longer says just sss_cache but
> e.g. sssctl cache-expire or whatever the command will be called) into
> /usr/share/man/man8/sssctl-cache-expire >
> IIRC that's how "man git $cmd" also works.
Okay no problem, hopefully there will be no confusion with other sssctl
commands containing only --help information.
Hmm, good point. Then perhaps we don't have to care at all?
I mean, the sss_debuglevel manpage is not exactly verbose :)
And the deprecation of the commands could be done as a simple shell
wrapper that would print "Redirecting to sssctl $command" and then just
(I guess since the path in this wrapper should be absolute and on the
source level the path is configurable, the shell wrapper should be a
configure .in file, but that's a technical detail..)
If I understand correctly, sss_cache.c code can be moved into a new function
sssctl_cache_expire in sssctl_cache.c and similar for sss_debuglevel.c into
Yes, each of those files is a sssctl command.