I realized my template that generates tevent request has still braces around debug message and few of them got in.
On (17/06/16 12:00), Pavel Březina wrote:
I realized my template that generates tevent request has still braces around debug message and few of them got in. From 8a05ccc9321041ec02864e1950cc35823b690125 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 17 Jun 2016 11:59:15 +0200 Subject: [PATCH] Remove braces from DEBUG statements
src/providers/ad/ad_subdomains.c | 2 +- src/providers/ipa/ipa_sudo_async.c | 4 ++-- src/providers/krb5/krb5_child.c | 2 +- src/providers/ldap/sdap.c | 2 +- src/responder/common/responder_cache_req.c | 4 ++-- src/responder/ifp/ifp_groups.c | 2 +- src/responder/sudo/sudosrv_get_sudorules.c | 2 +- src/tests/cmocka/test_negcache.c | 2 +- src/tests/common_dom.c | 4 ++-- 9 files changed, 12 insertions(+), 12 deletions(-)
you missed one
diff --git a/src/util/sss_semanage.c b/src/util/sss_semanage.c index d76677e..81068da 100644 --- a/src/util/sss_semanage.c +++ b/src/util/sss_semanage.c @@ -203,7 +203,7 @@ static int sss_semanage_user_mod(semanage_handle_t *handle, ret = semanage_seuser_modify_local(handle, key, seuser); if (ret != 0) { DEBUG(SSSDBG_CRIT_FAILURE, - ("Could not modify login mapping for %s\n"), login_name); + "Could not modify login mapping for %s\n", login_name); ret = EIO; goto done; }
and there are some in src/responder/pam/pam_LOCAL_domain.c after expansion of macros NULL_CHECK_OR_JUMP and NEQ_CHECK_OR_JUMP But squasing change in src/util/sss_semanage.c is enough for me.
BTW nice catch.
LS
On 06/17/2016 06:59 PM, Lukas Slebodnik wrote:
On (17/06/16 12:00), Pavel Březina wrote:
I realized my template that generates tevent request has still braces around debug message and few of them got in. From 8a05ccc9321041ec02864e1950cc35823b690125 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 17 Jun 2016 11:59:15 +0200 Subject: [PATCH] Remove braces from DEBUG statements
src/providers/ad/ad_subdomains.c | 2 +- src/providers/ipa/ipa_sudo_async.c | 4 ++-- src/providers/krb5/krb5_child.c | 2 +- src/providers/ldap/sdap.c | 2 +- src/responder/common/responder_cache_req.c | 4 ++-- src/responder/ifp/ifp_groups.c | 2 +- src/responder/sudo/sudosrv_get_sudorules.c | 2 +- src/tests/cmocka/test_negcache.c | 2 +- src/tests/common_dom.c | 4 ++-- 9 files changed, 12 insertions(+), 12 deletions(-)
you missed one
diff --git a/src/util/sss_semanage.c b/src/util/sss_semanage.c index d76677e..81068da 100644 --- a/src/util/sss_semanage.c +++ b/src/util/sss_semanage.c @@ -203,7 +203,7 @@ static int sss_semanage_user_mod(semanage_handle_t *handle, ret = semanage_seuser_modify_local(handle, key, seuser); if (ret != 0) { DEBUG(SSSDBG_CRIT_FAILURE,
("Could not modify login mapping for %s\n"), login_name);
"Could not modify login mapping for %s\n", login_name); ret = EIO; goto done; }and there are some in src/responder/pam/pam_LOCAL_domain.c after expansion of macros NULL_CHECK_OR_JUMP and NEQ_CHECK_OR_JUMP But squasing change in src/util/sss_semanage.c is enough for me.
BTW nice catch.
LS
New patch attached.
On (18/06/16 15:23), Pavel Březina wrote:
On 06/17/2016 06:59 PM, Lukas Slebodnik wrote:
On (17/06/16 12:00), Pavel Březina wrote:
I realized my template that generates tevent request has still braces around debug message and few of them got in. From 8a05ccc9321041ec02864e1950cc35823b690125 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 17 Jun 2016 11:59:15 +0200 Subject: [PATCH] Remove braces from DEBUG statements
src/providers/ad/ad_subdomains.c | 2 +- src/providers/ipa/ipa_sudo_async.c | 4 ++-- src/providers/krb5/krb5_child.c | 2 +- src/providers/ldap/sdap.c | 2 +- src/responder/common/responder_cache_req.c | 4 ++-- src/responder/ifp/ifp_groups.c | 2 +- src/responder/sudo/sudosrv_get_sudorules.c | 2 +- src/tests/cmocka/test_negcache.c | 2 +- src/tests/common_dom.c | 4 ++-- 9 files changed, 12 insertions(+), 12 deletions(-)
you missed one
diff --git a/src/util/sss_semanage.c b/src/util/sss_semanage.c index d76677e..81068da 100644 --- a/src/util/sss_semanage.c +++ b/src/util/sss_semanage.c @@ -203,7 +203,7 @@ static int sss_semanage_user_mod(semanage_handle_t *handle, ret = semanage_seuser_modify_local(handle, key, seuser); if (ret != 0) { DEBUG(SSSDBG_CRIT_FAILURE,
("Could not modify login mapping for %s\n"), login_name);
"Could not modify login mapping for %s\n", login_name); ret = EIO; goto done; }and there are some in src/responder/pam/pam_LOCAL_domain.c after expansion of macros NULL_CHECK_OR_JUMP and NEQ_CHECK_OR_JUMP But squasing change in src/util/sss_semanage.c is enough for me.
BTW nice catch.
LS
New patch attached.
From ca2aa5609087f45449bb8eef8aec3501ddd2bc3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 17 Jun 2016 11:59:15 +0200 Subject: [PATCH 01/26] Remove braces from DEBUG statements
src/providers/ad/ad_subdomains.c | 2 +- src/providers/ipa/ipa_sudo_async.c | 4 ++-- src/providers/krb5/krb5_child.c | 2 +- src/providers/ldap/sdap.c | 2 +- src/responder/common/responder_cache_req.c | 4 ++-- src/responder/ifp/ifp_groups.c | 2 +- src/responder/pam/pam_LOCAL_domain.c | 34 +++++++++++++++--------------- src/responder/sudo/sudosrv_get_sudorules.c | 2 +- src/tests/cmocka/test_negcache.c | 2 +- src/tests/common_dom.c | 4 ++-- src/util/sss_semanage.c | 2 +- 11 files changed, 30 insertions(+), 30 deletions(-)
ACK
http://sssd-ci.duckdns.org/logs-test/job/1/07/summary.html
LS
On (18/06/16 18:14), Lukas Slebodnik wrote:
On (18/06/16 15:23), Pavel Březina wrote:
On 06/17/2016 06:59 PM, Lukas Slebodnik wrote:
On (17/06/16 12:00), Pavel Březina wrote:
I realized my template that generates tevent request has still braces around debug message and few of them got in. From 8a05ccc9321041ec02864e1950cc35823b690125 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 17 Jun 2016 11:59:15 +0200 Subject: [PATCH] Remove braces from DEBUG statements
src/providers/ad/ad_subdomains.c | 2 +- src/providers/ipa/ipa_sudo_async.c | 4 ++-- src/providers/krb5/krb5_child.c | 2 +- src/providers/ldap/sdap.c | 2 +- src/responder/common/responder_cache_req.c | 4 ++-- src/responder/ifp/ifp_groups.c | 2 +- src/responder/sudo/sudosrv_get_sudorules.c | 2 +- src/tests/cmocka/test_negcache.c | 2 +- src/tests/common_dom.c | 4 ++-- 9 files changed, 12 insertions(+), 12 deletions(-)
you missed one
diff --git a/src/util/sss_semanage.c b/src/util/sss_semanage.c index d76677e..81068da 100644 --- a/src/util/sss_semanage.c +++ b/src/util/sss_semanage.c @@ -203,7 +203,7 @@ static int sss_semanage_user_mod(semanage_handle_t *handle, ret = semanage_seuser_modify_local(handle, key, seuser); if (ret != 0) { DEBUG(SSSDBG_CRIT_FAILURE,
("Could not modify login mapping for %s\n"), login_name);
"Could not modify login mapping for %s\n", login_name); ret = EIO; goto done; }and there are some in src/responder/pam/pam_LOCAL_domain.c after expansion of macros NULL_CHECK_OR_JUMP and NEQ_CHECK_OR_JUMP But squasing change in src/util/sss_semanage.c is enough for me.
BTW nice catch.
LS
New patch attached.
From ca2aa5609087f45449bb8eef8aec3501ddd2bc3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 17 Jun 2016 11:59:15 +0200 Subject: [PATCH 01/26] Remove braces from DEBUG statements
src/providers/ad/ad_subdomains.c | 2 +- src/providers/ipa/ipa_sudo_async.c | 4 ++-- src/providers/krb5/krb5_child.c | 2 +- src/providers/ldap/sdap.c | 2 +- src/responder/common/responder_cache_req.c | 4 ++-- src/responder/ifp/ifp_groups.c | 2 +- src/responder/pam/pam_LOCAL_domain.c | 34 +++++++++++++++--------------- src/responder/sudo/sudosrv_get_sudorules.c | 2 +- src/tests/cmocka/test_negcache.c | 2 +- src/tests/common_dom.c | 4 ++-- src/util/sss_semanage.c | 2 +- 11 files changed, 30 insertions(+), 30 deletions(-)
ACK
master: c02b8482375837b57cb618ed56d4bede0e006d9d
LS
sssd-devel@lists.fedorahosted.org
-
Lukas Slebodnik -
Pavel Březina