On Thu, Apr 04, 2013 at 12:12:19PM +0200, Ondrej Kos wrote:
On 04/04/2013 11:31 AM, Jakub Hrozek wrote:
>On Thu, Apr 04, 2013 at 11:17:05AM +0200, Jakub Hrozek wrote:
>>On Thu, Apr 04, 2013 at 08:57:03AM +0200, Lukas Slebodnik wrote:
>>>On (03/04/13 14:13), Lukas Slebodnik wrote:
>>>>hi,
>>>>
>>>>There are no more any warnings in fedora 19 with attached patches.
>>>>I think, that they are false positive, but I don't like warnings.
>>>>
>>>>LS
>>>
>>>I found another initialization bug, but I am not sure, how to fix it.
>>>src/providers/ipa/ipa_dyndns.c: In function
'ipa_dyndns_update_send':
>>>src/providers/ipa/ipa_dyndns.c:245:39: warning: 'state' is used
uninitialized in this function [-Wuninitialized]
>>>
>>>In file src/providers/ipa/ipa_dyndns.c
>>> 234 static struct tevent_req *
>>> 235 ipa_dyndns_update_send(struct ipa_options *ctx)
>>> 236 {
>>> 237 int ret;
>>> 238 char *iface;
>>> 239 struct ipa_dyndns_ctx *state;
>>> 240 struct ifaddrs *ifaces;
>>> 241 struct ifaddrs *ifa;
>>> 242 struct ipa_ipaddress *address;
>>> 243 struct tevent_req *req, *subreq;
>>> 244 size_t addrsize;
>>> 245 struct sdap_id_ctx *id_ctx =
state->ipa_ctx->id_ctx->sdap_id_ctx;
>>> ^^^^^
>>> this could not work
>>>
>>>Introduced in patch:584eda08 Jakub Hrozek 2013-03-25 22:54:48 +0100
>>>
>>>LS
>>
>>Oh, wonderful. This code will go away with the new dyndns patches
>>anyway, so I can either fix it now with a separate patch or send the
>>whole bunch.
>
>Let's fix in now, that's a crasher bug. Sorry, the whole dyndns branch
>works in my tree because I had another patches on top.
>
Ack
Ondra
Pushed to master. Thank you for catching this!