URL:
https://github.com/SSSD/sssd/pull/483
Title: #483: Password change with two factor authentication
jhrozek commented:
"""
Coverity found some complaint:
```
Error: CHECKED_RETURN (CWE-252):
sssd-1.16.1/src/sss_client/pam_sss.c:2188: check_return: Calling "pam_get_data"
without checking return value (as is done elsewhere 5 out of 6 times).
sssd-1.16.1/src/sss_client/pam_sss.c:2092: example_assign: Example 1: Assigning:
"pam_status" = return value from "pam_get_data(pamh,
"pam_sss:authtok_type", (void const **)&authtok_type)".
sssd-1.16.1/src/sss_client/pam_sss.c:2094: example_checked: Example 1 (cont.):
"pam_status" has its value checked in "pam_status != 0".
sssd-1.16.1/src/sss_client/pam_sss.c:2099: example_assign: Example 2: Assigning:
"pam_status" = return value from "pam_get_data(pamh,
"pam_sss:authtok_size", (void const **)&authtok_size)".
sssd-1.16.1/src/sss_client/pam_sss.c:2101: example_checked: Example 2 (cont.):
"pam_status" has its value checked in "pam_status != 0".
sssd-1.16.1/src/sss_client/pam_sss.c:2106: example_assign: Example 3: Assigning:
"pam_status" = return value from "pam_get_data(pamh,
"pam_sss:authtok_data", (void const **)&authtok_data)".
sssd-1.16.1/src/sss_client/pam_sss.c:2108: example_checked: Example 3 (cont.):
"pam_status" has its value checked in "pam_status != 0".
sssd-1.16.1/src/sss_client/pam_sss.c:2519: example_checked: Example 4:
"pam_get_data(pamh, "pam_sss:password_expired_flag", (void const
**)&exp_data)" has its value checked in "pam_get_data(pamh,
"pam_sss:password_expired_flag", (void const **)&exp_data) == 0".
sssd-1.16.1/src/sss_client/pam_sss.c:2546: example_checked: Example 5:
"pam_get_data(pamh, "pam_sss:password_expired_flag", (void const
**)&exp_data)" has its value checked in "pam_get_data(pamh,
"pam_sss:password_expired_flag", (void const **)&exp_data) != 0".
# 2186| int ret;
# 2187| const int *exp_data = NULL;
# 2188|-> pam_get_data(pamh, PWEXP_FLAG, (const void **) &exp_data);
# 2189|
# 2190| /* we query for the old password during PAM_PRELIM_CHECK to make
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/483#issuecomment-356375056