On 06/19/2010 11:24 AM, Dmitri Pal wrote:
0001 - #547
Nack. Please update contrib/sssd.spec.in to require the correct minimum
collection version. Otherwise it looks fine. (But I'm not sure if we
want to include this in 1.2.x or hold it for 1.3.x; I'm leaning towards
the latter)
0002 - memory leaks found in the unit test while testing 0001
Ack for master. Not worth backporting to 1.2.x.
Patches are independent.
Question: Should we run Coverity against the unit tests too?
I think we should because errors in the unit test most likely obscure
the errors in the code they test.
I was about to open a ticket on the matter but decided to ask first.
I have been running Coverity against the tests as well as the main code,
specifically because running against the tests can expose additional
code paths that Coverity may not have discovered.
Coverity actually did detect the memory leak you fixed in 0002, but I
had marked it as "ignore" (and therefore not critical to fix in 1.2.1)
because it impacted only the unit test (I carefully verified this).
--
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/