URL: https://github.com/SSSD/sssd/pull/596 Author: amitkumar50 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section Action: opened
PR body: """ Upstream Request: Instead of enabling domains using the "domains" option in [sssd] section we could have [domain/*] option "enabled". This would allow admins to configure and enable domain in the same snippet file.
This Fix would be submitted in 2 patches: Patch-1(This Patch): - Introduces 'enabled' option in domain section - Introduces 'CONFDB_DOMAIN_ENABLED' variable to retrieve enabled value from confdb - Code to call start_service() routine only for domains having enabled=1
Patch-2(Upcoming): - Would remove 'domains' option from sssd section. - Would remove corresponding code to parse 'domains' option - Providing a check that atlest One domain have enabled option set.
Resolves: https://pagure.io/SSSD/sssd/issue/3735 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/596/head:pr596 git checkout pr596
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-396217823
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-396217822
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
sumit-bose commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-396220212
URL: https://github.com/SSSD/sssd/pull/596 Author: amitkumar50 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/596/head:pr596 git checkout pr596
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
mzidek-rh commented: """ Hi Amit,
sorry, but the solution you propose is not backward compatible.
We need: - current SSSD configurations to work as they do now - define the behavior of SSSD with both the "domains = a,b,c" and "enabled = True/False" in the domain sections.
IMO it should be a configuration error when the two approaches are used simultaneously and should be reported in the logs. It would be also good to add a rule to the config file validator to report such configuration as invalid. But we do not plan to remove the current "domains" option. """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-396940482
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
amitkumar50 commented: """ Hello @mzidek-rh Thanks for Comments. I read this from upstream ticket:
Instead of enabling domains using the "domains" option in [sssd] section we could have [domain/*] option "enabled". This would allow admins to configure and enable domain in the same snippet file.
If exact requirement is this:
- define the behavior of SSSD with both the "domains = a,b,c" and "enabled = True/False" in the domain sections.
- Should be a configuration error when the two approaches are used simultaneously and should be reported in the logs.
- But we do not plan to remove the current "domains" option.
I will code accordingly. But lets update the same in upstream ticket as well. Your thoughts!!
"""
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-396944218
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
jhrozek commented: """ Right, the upstream ticket was unclear, but in general, we never break backwards compatibility in SSSD. """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-396950274
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
jhrozek commented: """ I'm actually thinking that this is a large enough change that it needs a design document and discussion on the list. Amit, I think @mzidek-rh and I can help write up the design document if you are interested in working on this feature. I think it would be best to first discuss the details on the list, because otherwise you might spend your time on something that might not later be accepted. """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-397031857
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
amitkumar50 commented: """ @jhrozek @mzidek-rh Yup Thanks for support. I would be working on this feature. @mzidek-rh can go a head to write up design doc .. That would be helpful... I would also add up my thoughts during the process. """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-397169484
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
pbrezina commented: """ @amitkumar50 Bump, is there any work in progress?
I think we should prioritize this as without this feature, the configuration snippets are mostly useless as you can't just drop in a domain config. """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-532138349
URL: https://github.com/SSSD/sssd/pull/596 Author: amitkumar50 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/596/head:pr596 git checkout pr596
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
mzidek-gh commented: """ Hi, I will close this PR. We can open a new one if we have new set of patches. Please re-open if you disagree. """
See the full comment at https://github.com/SSSD/sssd/pull/596#issuecomment-603100492
sssd-devel@lists.fedorahosted.org