URL: https://github.com/SSSD/sssd/pull/646 Author: pbrezina Title: #646: proxy: access provider directly not through be_ctx Action: opened
PR body: """ See commit message for details.
Resolves: https://pagure.io/SSSD/sssd/issue/3812 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/646/head:pr646 git checkout pr646
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
jhrozek commented: """ This improves the situation in the sense that the proxy provider now works, but I'm seeing this crash on shutdown: ``` Sep 06 14:29:55 client.ipa.test systemd-coredump[11292]: Process 11281 (sssd_be) of user 0 dumped core.
Stack trace of thread 11281: #0 0x00007f477424acf0 _dbus_list_unlink (libdbus-1.so.3) #1 0x00007f477424ad69 _dbus_list_remove_link (libdbus-1.so.3) #2 0x00007f4774239c71 _dbus_message_remove_counter (libdbus-1.so.3) #3 0x00007f477422d49d free_outgoing_message (libdbus-1.so.3) #4 0x00007f477422ef81 _dbus_connection_last_unref (libdbus-1.so.3) #5 0x00007f4774aa8191 sbus_connection_release (libsss_sbus.so) #6 0x00007f4774aa81ef sbus_connection_destructor (libsss_sbus.so) #7 0x00007f477446f011 _tc_free_internal (libtalloc.so.2) #8 0x00007f4774aa931a sbus_connection_free_handler (libsss_sbus.so) #9 0x00007f4774689541 tevent_common_loop_timer_delay (libtevent.so.0) #10 0x00007f477468a557 epoll_event_loop_once (libtevent.so.0) #11 0x00007f4774688ba7 std_event_loop_once (libtevent.so.0) #12 0x00007f4774684fed _tevent_loop_once (libtevent.so.0) #13 0x00007f477468520b tevent_common_loop_wait (libtevent.so.0) #14 0x00007f4774688b47 std_event_loop_wait (libtevent.so.0) #15 0x00007f477856cb15 server_loop (libsss_util.so) #16 0x000000000040a4a9 main (sssd_be) #17 0x00007f4773b70f2a __libc_start_main (libc.so.6) #18 0x0000000000407daa _start (sssd_be) ``` """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-419115356
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
jhrozek commented: """ btw I'm seeing the crash with PR #647 applied..but only with the proxy domain, not e.g. IPA domain """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-419116599
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
pbrezina commented: """ I can not reproduce this issue. Do you have any reproducer or machine where I can debug it? """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-419392530
URL: https://github.com/SSSD/sssd/pull/646 Author: pbrezina Title: #646: proxy: access provider directly not through be_ctx Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/646/head:pr646 git checkout pr646
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
pbrezina commented: """ I pushed new patches after debugging session with Jakub. """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-420624542
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
jhrozek commented: """ I'm very sorry for the slow review. Please ping me next time I forget about some patchset like this.
Anyway, I'm happy to confirm that the patches fix the issue. To be sure, I ran the RH QE tests twice without the patches and got two crash reports (jobs 2829402 and 2829398 in case anyone cares), then twice with the patches (jobs 2831660 and 2831658) with no crash.
-> ACK """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-425224330
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
jhrozek commented: """ btw I know Sumit wants to get some patches through CI, so I won't push the patches right away in order to not add even more load to CI at the moment.. """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-425224529
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
jhrozek commented: """ * master: f1f9af528f71f42ac41bb7a272f4f7d940fd3a0f b821ee3ca93beb94a7a9b22b6f7a205e4900212e 9245bf1afe6767a0412212bc0040e606ee850e7d 4c5a1afa0df41aac05d34455c6e54a6f52a8dd28 4ffe3ab9023ff858410256bc5c38a03d9cd88cf9 """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-425361992
URL: https://github.com/SSSD/sssd/pull/646 Author: pbrezina Title: #646: proxy: access provider directly not through be_ctx Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/646/head:pr646 git checkout pr646
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx
alexey-tikhonov commented: """
This improves the situation in the sense that the proxy provider now works, but I'm seeing this crash on shutdown:
Sep 06 14:29:55 client.ipa.test systemd-coredump[11292]: Process 11281 (sssd_be) of user 0 dumped core. Stack trace of thread 11281: #0 0x00007f477424acf0 _dbus_list_unlink (libdbus-1.so.3) #1 0x00007f477424ad69 _dbus_list_remove_link (libdbus-1.so.3) #2 0x00007f4774239c71 _dbus_message_remove_counter (libdbus-1.so.3) #3 0x00007f477422d49d free_outgoing_message (libdbus-1.so.3) #4 0x00007f477422ef81 _dbus_connection_last_unref (libdbus-1.so.3) #5 0x00007f4774aa8191 sbus_connection_release (libsss_sbus.so) #6 0x00007f4774aa81ef sbus_connection_destructor (libsss_sbus.so) #7 0x00007f477446f011 _tc_free_internal (libtalloc.so.2) #8 0x00007f4774aa931a sbus_connection_free_handler (libsss_sbus.so) #9 0x00007f4774689541 tevent_common_loop_timer_delay (libtevent.so.0) #10 0x00007f477468a557 epoll_event_loop_once (libtevent.so.0) #11 0x00007f4774688ba7 std_event_loop_once (libtevent.so.0) #12 0x00007f4774684fed _tevent_loop_once (libtevent.so.0) #13 0x00007f477468520b tevent_common_loop_wait (libtevent.so.0) #14 0x00007f4774688b47 std_event_loop_wait (libtevent.so.0) #15 0x00007f477856cb15 server_loop (libsss_util.so) #16 0x000000000040a4a9 main (sssd_be) #17 0x00007f4773b70f2a __libc_start_main (libc.so.6) #18 0x0000000000407daa _start (sssd_be)
For the record: the same crash was seen in https://bugzilla.redhat.com/show_bug.cgi?id=1783169 so I think it was not fixed by this PR. """
See the full comment at https://github.com/SSSD/sssd/pull/646#issuecomment-567165154
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
jhrozek
-
pbrezina