URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: opened
PR body: """ The key-id might not be sufficient to identify a certificate on a Smartcard since it is possible that multiple certificates will use the same key.
This patch adds the certificate label to the Smartcard authtok item to about the ambiguity if the key-id is used for multiple certificates.
Currently the key-id read from the Smartcard is used as key value for the gdm choice list dialog. Since it might be possible that multiple certificates use the same key and hence the same key-id this is not a suitable value.
With this patch the string representation of a numerial counter is used.
Resolves: https://github.com/SSSD/sssd/issues/5400 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401
URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401
URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: +Bugzilla
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
alexey-tikhonov commented: """ `adds the certificate label to the Smartcard authtok item to about the ambiguity` -- "to resolve the ambiguity"? """
See the full comment at https://github.com/SSSD/sssd/pull/5401#issuecomment-742807052
URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
sumit-bose commented: """
`adds the certificate label to the Smartcard authtok item to about the ambiguity` -- "to resolve the ambiguity"?
Thanks, the latest version fixes the commit message.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5401#issuecomment-743281343
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
alexey-tikhonov commented: """ Now in `pamsrv_p11.c::pack_cert_data()` we pass `label` to `pam_sss` twice: once as part of a `prompt` and once as a `label`, right?
I have few very minor remarks, please see inline. """
See the full comment at https://github.com/SSSD/sssd/pull/5401#issuecomment-743449279
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
alexey-tikhonov commented: """ Thanks for the updated version. ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5401#issuecomment-746280115
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
sumit-bose commented: """ I'm sorry, the latest version contained an unrelated patch, before pushing I have removed the patch. """
See the full comment at https://github.com/SSSD/sssd/pull/5401#issuecomment-746421144
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
sumit-bose commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5401
* `master` * f633f37e712cb0f7524a2ee257e15f34468149b4 - add tests multiple certs same id * b8800d3e1b43f2eb28b2df7adb2bcb323bf2d1f1 - pam_sss: add certificate label to reply to pam_sss * 8b6be52e95e953ae0431676de0b8c8be7a3262bc - authtok: add label to Smartcard token * 1b9b7f5a635ede8eee90d13bfe0e1f87e51191a9 - pam_sss: use unique id for gdm choice list
"""
See the full comment at https://github.com/SSSD/sssd/pull/5401#issuecomment-746422457
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401
sssd-devel@lists.fedorahosted.org