-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/08/2010 05:20 AM, Sumit Bose wrote:
On Thu, Jan 07, 2010 at 04:30:48PM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 01/07/2010 03:19 PM, Stephen Gallagher wrote:
>> On 01/07/2010 03:13 PM, Stephen Gallagher wrote:
>>> As we have been discussing lately, I looked into how difficult it would
>>> be to split our common tools into their own shared libraries. I
>>> experimented with dhash and found that it was pretty easy to do. (Thanks
>>> Automake and Libtool!)
>>
>>> The attached patch builds libdhash as a .so and packages it in its own
>>> subpackage (and -devel subpackage).
>>
>>
>>
>> Whoops, I had a typo in the Requires: section. Fixed and new patch attached.
>>
>
> Several changes made to the patch after discussion with Simo.
>
> I have bumped the version of libdhash to 0.4.0 to account for the recent
> changes that were made to the ABI.
>
> The subpackages being built from the SSSD for libdhash will now be
> versioned separately (in the previous patch, it shared a version with
> the sssd)
>
> I left the code to detect a system copy of libdhash in place, but we
> will force the use of the in-tree copy for now (until such time in the
> future as we separate it into its own project/source repository)
>
>
I think it would be nice to have the COPYING file in the libdhash
package and dhash_example.c and maybe dhash_test.c in the libdhash-devel
package together with a short README which tells the user that the
documentation can be found in dhash.h.
bye,
Sumit
Ask, and you shall receive.
New patches attached.
Patch 0001: Fix missing license information for libdhash
Patch 0002: Updated patch splitting off libdhash, including COPYING
files and examples/ files. I moved the example sources into their own
subdirectory to make it simpler to include in the spec file.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAktHjxIACgkQeiVVYja6o6MAUwCgim32KEHhAgP0ya0lnhIE+S3J
VDoAoKiMbFjI9hQdGhXp2FRhGJhEQfG9
=x2IV
-----END PGP SIGNATURE-----