On Tue, Jun 11, 2013 at 10:04:06AM +0200, Jakub Hrozek wrote:
> On Tue, Jun 11, 2013 at 09:11:58AM +0200, Sumit Bose wrote:
> > On Mon, Jun 10, 2013 at 09:30:43PM +0200, Jakub Hrozek wrote:
> > > Another Coverity issue.
> >
> > > From b01b9bc392cd21e72cdb04fa3893091fcac0f8e0 Mon Sep 17 00:00:00 2001
> > > From: Jakub Hrozek <jhrozek(a)redhat.com>
> > > Date: Mon, 10 Jun 2013 21:29:25 +0200
> > > Subject: [PATCH] Fix allocation check in the AD provider
> > >
> > >
https://fedorahosted.org/sssd/ticket/1976
> > > ---
> > > src/providers/ad/ad_init.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/src/providers/ad/ad_init.c b/src/providers/ad/ad_init.c
> > > index
09ba384be6d22ac57f8ac82a4443dc432b41d463..f3c1609dedb6d1ad650b598da53546dce6cf6345 100644
> > > --- a/src/providers/ad/ad_init.c
> > > +++ b/src/providers/ad/ad_init.c
> > > @@ -143,7 +143,7 @@ sssm_ad_id_init(struct be_ctx *bectx,
> > > ad_ctx->ldap_ctx = sdap_ctx->conn;
> > >
> > > ad_ctx->gc_ctx = sdap_id_ctx_conn_add(sdap_ctx,
ad_options->service->gc);
> > > - if (sdap_ctx == NULL) {
> > > + if (sdap_ctx->gc_ctx == NULL) {
> >
> > I guess you meant ad_ctx->gc_ctx == NULL ?
> >
> > bye,
> > Sumit
>
> This is exactly why I prefer reviews even for one-liner patches (any why
> I should start running Coverity fixes through Coverity prior to sending
> them out).
>
> Thanks for catching this, a new patch is attached.
ACK
bye,
Sumit