I fixed a handful of alignment problems in sss_client and nss responder. Enumerating group and passwd with getgrent and getpwent now works correctly on ARM.
Cheers, George McCollister
On Mon, Mar 01, 2010 at 09:52:12AM -0600, George McCollister wrote:
I fixed a handful of alignment problems in sss_client and nss responder. Enumerating group and passwd with getgrent and getpwent now works correctly on ARM.
Cheers, George McCollister
Thanks for the contribution. The patch looks fine, but it would be nice if you can use the SAFEALIGN_* macros from commit 'Improve safe alignment buffer handling macros' (6adf5b8a078f2b37f2d3d91cd060b891c2a7efaa) instead of calling memcpy directly?
bye, Sumit
I've attached a new version of the patch that uses the macros.
Regards, George McCollister
On 03/03/2010 10:14 AM, Sumit Bose wrote:
On Mon, Mar 01, 2010 at 09:52:12AM -0600, George McCollister wrote:
I fixed a handful of alignment problems in sss_client and nss responder. Enumerating group and passwd with getgrent and getpwent now works correctly on ARM.
Cheers, George McCollister
Thanks for the contribution. The patch looks fine, but it would be nice if you can use the SAFEALIGN_* macros from commit 'Improve safe alignment buffer handling macros' (6adf5b8a078f2b37f2d3d91cd060b891c2a7efaa) instead of calling memcpy directly?
bye, Sumit _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/04/2010 10:47 AM, George McCollister wrote:
I've attached a new version of the patch that uses the macros.
Regards, George McCollister
Ack.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/08/2010 10:33 AM, Stephen Gallagher wrote:
On 03/04/2010 10:47 AM, George McCollister wrote:
I've attached a new version of the patch that uses the macros.
Regards, George McCollister
Ack.
Pushed to master and 1-1-0.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org