On Fri, Sep 20, 2013 at 07:01:04PM +0200, Pavel Březina wrote:
On 09/20/2013 03:57 PM, Jakub Hrozek wrote:
>On Tue, Sep 17, 2013 at 02:09:08PM +0200, Pavel Březina wrote:
>>On 09/16/2013 05:22 PM, Jakub Hrozek wrote:
>>>I found these minor issues in our man pages, when triaging support
>>>issues with Red Hat GSS earlier today.
>>>
>>>The first patch changes the subtitle of the man pages. I wasn't
>>>completely sure if the title is set to "SSSD config file" on
purpose
>>>(after all they do describe the config file, just per-provider), but I
>>>think that at least the Kerberos locator man page should be fixed.
>>>
>>>The second patch fixes indentation of programlisting. The programlisting
>>>element makes the text in the element formatted verbatim, so it would
>>>have appeared too much to the right.
>>
>>Patch 1 Ack
>>Patch 2 Nack
>>
>>The listing is still to far to the right in comparison to other
>>listings. There should be no spaces in the source file.
>>
>>However, since ldap_user_search_filter is deprecated for few
>>versions already, cannot we remove it from master?
>>
>
>I'm not sure if we can remove it right away, but we can start printing a
>deprecation warning and remove it from docs, I think. The new search
>bases have been around sine 1.7.0, so I think deprecating the old way in
>1.12 is OK.
That is exactly what I meant. I should have been more specific.
Ack to both patches.
Thanks for the review.
Pushed to master only.