ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
On 08/08/2016 06:37 PM, Lukas Slebodnik wrote:
ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
Hello Lukas,
CI nearly passed: http://sssd-ci.duckdns.org/logs/job/51/10/summary.html RHEL7 didn't work at all. This is not connected.
Code: LGTM
Tests: Please, file ticket on writting tests for this issue with pam_wrapper.
I try your reproducer manually, after this I give you ack for this patch.
Regards
On 08/09/2016 09:04 AM, Petr Cech wrote:
On 08/08/2016 06:37 PM, Lukas Slebodnik wrote:
ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
Hello Lukas,
CI nearly passed: http://sssd-ci.duckdns.org/logs/job/51/10/summary.html RHEL7 didn't work at all. This is not connected.
Code: LGTM
Tests: Please, file ticket on writting tests for this issue with pam_wrapper.
I try your reproducer manually, after this I give you ack for this patch.
Manually reproducer before and after patch works how we expected.
=> ACK
On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote:
ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
From e501f791ee2e03b8eaea919a2f8ca4474773e3ba Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Mon, 8 Aug 2016 17:30:29 +0200 Subject: [PATCH] NSS: Use correct name for invalidating memory cache
After refactoring of sysdb, we get and internal fully qualified name from backend in org.freedesktop.sssd.dataprovider_rev.initgrCheck Previously we got short name and we created fq name in nss_update_initgr_memcache. Memory cache still need to use short names if it was specified.
In fill_pwent() we use the sized_output_name() to store the name in the memcache, can we use the same here?
On (09/08/16 10:21), Jakub Hrozek wrote:
On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote:
ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
From e501f791ee2e03b8eaea919a2f8ca4474773e3ba Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Mon, 8 Aug 2016 17:30:29 +0200 Subject: [PATCH] NSS: Use correct name for invalidating memory cache
After refactoring of sysdb, we get and internal fully qualified name from backend in org.freedesktop.sssd.dataprovider_rev.initgrCheck Previously we got short name and we created fq name in nss_update_initgr_memcache. Memory cache still need to use short names if it was specified.
In fill_pwent() we use the sized_output_name() to store the name in the memcache, can we use the same here?
Sure,
LS
On 08/09/2016 07:10 PM, Lukas Slebodnik wrote:
On (09/08/16 10:21), Jakub Hrozek wrote:
On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote:
ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
From e501f791ee2e03b8eaea919a2f8ca4474773e3ba Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Mon, 8 Aug 2016 17:30:29 +0200 Subject: [PATCH] NSS: Use correct name for invalidating memory cache
After refactoring of sysdb, we get and internal fully qualified name from backend in org.freedesktop.sssd.dataprovider_rev.initgrCheck Previously we got short name and we created fq name in nss_update_initgr_memcache. Memory cache still need to use short names if it was specified.
In fill_pwent() we use the sized_output_name() to store the name in the memcache, can we use the same here?
Sure,
LS
Hi Lukas, Jakub,
LGTM, I will wait for new CI.
Regards
On 08/10/2016 07:30 AM, Petr Cech wrote:
On 08/09/2016 07:10 PM, Lukas Slebodnik wrote:
On (09/08/16 10:21), Jakub Hrozek wrote:
On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote:
ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
From e501f791ee2e03b8eaea919a2f8ca4474773e3ba Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Mon, 8 Aug 2016 17:30:29 +0200 Subject: [PATCH] NSS: Use correct name for invalidating memory cache
After refactoring of sysdb, we get and internal fully qualified name from backend in org.freedesktop.sssd.dataprovider_rev.initgrCheck Previously we got short name and we created fq name in nss_update_initgr_memcache. Memory cache still need to use short names if it was specified.
In fill_pwent() we use the sized_output_name() to store the name in the memcache, can we use the same here?
Sure,
LS
Hi Lukas, Jakub,
LGTM, I will wait for new CI.
Hi,
CI passed: http://sssd-ci.duckdns.org/logs/job/51/22/summary.html
Manual testing passed.
=> ACK
Regards
On Wed, Aug 10, 2016 at 08:08:03AM +0200, Petr Cech wrote:
On 08/10/2016 07:30 AM, Petr Cech wrote:
On 08/09/2016 07:10 PM, Lukas Slebodnik wrote:
On (09/08/16 10:21), Jakub Hrozek wrote:
On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote:
ehlo,
yet another patch which fixes issues caused by sysdb refactoring.
reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups.
I am looking forward to the pam_wrapper So we can test it in upstream.
LS
From e501f791ee2e03b8eaea919a2f8ca4474773e3ba Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Mon, 8 Aug 2016 17:30:29 +0200 Subject: [PATCH] NSS: Use correct name for invalidating memory cache
After refactoring of sysdb, we get and internal fully qualified name from backend in org.freedesktop.sssd.dataprovider_rev.initgrCheck Previously we got short name and we created fq name in nss_update_initgr_memcache. Memory cache still need to use short names if it was specified.
In fill_pwent() we use the sized_output_name() to store the name in the memcache, can we use the same here?
Sure,
LS
Hi Lukas, Jakub,
LGTM, I will wait for new CI.
Hi,
CI passed: http://sssd-ci.duckdns.org/logs/job/51/22/summary.html
Manual testing passed.
=> ACK
ACK from me as well.
* master: 6f0a0ae7599e3947c0b2e4649039f85829e57637
sssd-devel@lists.fedorahosted.org