On 06/02/2010 09:13 AM, Stephen Gallagher wrote:
On 06/01/2010 03:56 PM, Sumit Bose wrote:
> On Tue, Jun 01, 2010 at 01:11:32PM -0400, Stephen Gallagher wrote:
>> On 06/01/2010 05:41 AM, Sumit Bose wrote:
>>> Hi,
>>>
>>> this patch removes the service groups from the IPA access provider
>>> because with working memberOf attributed for the service objects they
>>> are not necessary anymore.
>>>
>>> For your convenience I have attached patches for the master and the 1.2
>>> branch.
>>
>>
>> I'm sorry, Sumit. Can you explain what this patch is supposed to be
>> doing? I only see it removing code, but I don't see where the memberOf
>> has anything to do with it.
>
> When the services and service groups were introduced in the IPA server
> the memeberOf attribute was not set if a service was added to a service
> group. I first didn't realize that this was some kind of bug and read
> the service groups and all their member from the IPA server to find out
> which service is in which group. Then I talked to Rob and learned that
> it was intended to have the memberOf attribute set for the services and
> that he would provide a fix. I have change the check_service() call to
> check only the memberOf attribute and not run over all groups and forgot
> to remove the code which read the service groups. So it is just a
> leftover.
>
> HTH
>
> bye,
> Sumit
Ok, I follow it now.
Master: Ack.
Pushed to master.
--
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/