URL: https://github.com/SSSD/sssd/pull/213 Author: lslebodn Title: #213: intg: Remove bashism from intgcheck-prepare Action: opened
PR body: """ env variable UID is not defined in all shells (eg. dash)
================================ FAILURES =================================== ________________________ test_kcm_mem_init_list_destroy ________________________ Traceback (most recent call last): File "/home/build/sssd/src/tests/intg/test_kcm.py", line 198, in test_kcm_mem_init_list_destroy kcm_init_list_destroy(testenv) File "/home/build/sssd/src/tests/intg/test_kcm.py", line 183, in kcm_init_list_destroy exp_ccname = testenv.ccname() File "/home/build/sssd/src/tests/intg/test_kcm.py", line 45, in ccname my_uid = self.my_uid() File "/home/build/sssd/src/tests/intg/test_kcm.py", line 41, in my_uid return int(s_myuid) ValueError: invalid literal for int() with base 10: ''
And we already use different approach in top level Makefile.am 3488) $(INTGCHECK_CONFIGURE_FLAGS) \ 3489) CFLAGS="$$CFLAGS $(AM_CFLAGS) -DKCM_PEER_UID=$$(id -u)"; \ 3490) $(MAKE) $(AM_MAKEFLAGS) ; \ """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/213/head:pr213 git checkout pr213
URL: https://github.com/SSSD/sssd/pull/213 Author: lslebodn Title: #213: intg: Remove bashism from intgcheck-prepare Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/213/head:pr213 git checkout pr213
URL: https://github.com/SSSD/sssd/pull/213 Title: #213: intg: Remove bashism from intgcheck-prepare
jhrozek commented: """ retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/213#issuecomment-289805740
URL: https://github.com/SSSD/sssd/pull/213 Title: #213: intg: Remove bashism from intgcheck-prepare
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/213 Author: lslebodn Title: #213: intg: Remove bashism from intgcheck-prepare Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/213/head:pr213 git checkout pr213
URL: https://github.com/SSSD/sssd/pull/213 Title: #213: intg: Remove bashism from intgcheck-prepare
lslebodn commented: """ master: * f75ba99fc8dd64e45af2f642d9fb7660860fd28f """
See the full comment at https://github.com/SSSD/sssd/pull/213#issuecomment-290001091
URL: https://github.com/SSSD/sssd/pull/213 Title: #213: intg: Remove bashism from intgcheck-prepare
Label: +Pushed
sssd-devel@lists.fedorahosted.org