URL:
https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
mzidek-rh commented:
"""
There is a tabulator instead of space after '=' sign
in Makefile.am:
```
458
459 dist_sbin_SCRIPTS = contrib/tools/sss_debuglevel
460
```
But as Lukas mentioned we should not put sss_debuglevel in the tarball directly,
but only the .in version and call the replace_script on it in the Makefile.am,
so that proper paths are expanded in the script (see how replace_script is used
in the Makefile.am for other files). So the configure.ac line should be removed
too.
Also I would not put this to the contrib directory because this is directory
that we use for things that are not packaged in the tarball or nice things that
someone creted but are not core parts of the project (like some helpful sripts
etc). Maybe a new directory src/tools/wrappers would be more appropriate?
@lslebodn do you have any proposal in this regard?
I can see these warnings when I run autoreconf -if indicating you forgot to remove
some lines from Makefile.am:
```
Makefile.am: installing 'build/depcomp'
Makefile.am:1685: warning: variable 'sss_debuglevel_SOURCES' is defined but no
program or
Makefile.am:1685: library has 'sss_debuglevel' as canonical name (possible typo)
Makefile.am:1688: warning: variable 'sss_debuglevel_LDADD' is defined but no
program or
Makefile.am:1688: library has 'sss_debuglevel' as canonical name (possible typo)
```
Bad indentation in src/tools/sssctl/sssctl.h
```
113 errno_t sssctl_debug_level(struct sss_cmdline *cmdline,
114 struct sss_tool_ctx *tool_ctx,
115 void *pvt);
^ bad indentation
```
In src/tools/sssctl/sssctl_logs.c, the config.h should be the first header that
is included (I think we do not follow this everywhere, but still..)
Another bad indentation in src/tools/sssctl/sssctl.h
```
101 errno_t sssctl_cache_expire(struct sss_cmdline *cmdline,
102 struct sss_tool_ctx *tool_ctx,
103 void *pvt);
104 ^^^ bad indentation
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/274#issuecomment-318339105