-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/17/2011 10:09 AM, Sumit Bose wrote:
> On Thu, Mar 17, 2011 at 09:57:22AM -0400, Stephen Gallagher wrote:
>
> When we added the Kerberos access provider (for support of .k5login), we
> forgot to include it in the SSSDConfig API schema.
>
> Fixes
https://bugzilla.redhat.com/show_bug.cgi?id=688491
>
>> NACK, test fails, please add
>
>> diff --git a/src/config/SSSDConfigTest.py b/src/config/SSSDConfigTest.py
>> index 60fb0a2..22370c0 100755
>> --- a/src/config/SSSDConfigTest.py
>> +++ b/src/config/SSSDConfigTest.py
>> @@ -693,7 +693,7 @@ class SSSDConfigTestSSSDDomain(unittest.TestCase):
>> 'ipa': ['id', 'auth', 'access',
'chpass'],
>> 'local': ['id', 'auth', 'chpass'],
>> 'ldap': ['id', 'auth', 'access',
'chpass'],
>> - 'krb5': ['auth', 'chpass'],
>> + 'krb5': ['auth', 'chpass',
'access'],
>> 'proxy': ['id', 'auth'],
>> 'simple': ['access'],
>> 'permit': ['access'],
>
See, this is exactly why I like to send reviews even for one-liners.
Thanks, I should have remembered to run the test. New patch attached.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk2CHaEACgkQeiVVYja6o6NnhgCgrwYDZUg45mJcc6saR5dmeHxc
gbQAn0DGn//M3mNpA5E55pSEBbO5gruZ
=IX5u
-----END PGP SIGNATURE-----