On Sun, 2013-01-06 at 14:25 +0100, Jakub Hrozek wrote:
On Sun, Jan 06, 2013 at 02:02:23PM +0100, Jakub Hrozek wrote:
> On Sun, Jan 06, 2013 at 12:28:22AM -0500, Simo Sorce wrote:
> > Minor cleanup.
> >
> > --
> > Simo Sorce * Red Hat, Inc * New York
>
> Ack.
Pushed to master and sssd-1-9.
By the way, if the file *was* actually needed here and the module was
just a unit test, then I think this specific case would be acceptable.
Unit tests can often benefit from knowing the internals and even testing
static functions would be very handy sometimes.
Yes I left it in sysdb-tests.c in fact, but it should be included only
if *really* needed and only for internal sysdb tests, or cross checks
for verifying internal behavior with returned results.
Simo.
--
Simo Sorce * Red Hat, Inc * New York