URL:
https://github.com/SSSD/sssd/pull/285
Title: #285: SSSCTL: Add primary or subdomain information
mzidek-rh commented:
"""
Sorry to jump late to the conversation, but I want to request one change to the patch.
We should really not use the word "subdomain" in any user facing information.
The problem is that we use this as an internal term to describe domain structures that are
attached to the primary domain and to witch the primary domain has established trust, but
it does not necessary need to be an actual subdomain of the primary domain, which may be
really confusing for the user.
For example I have an output:
```
# sssctl domain-list --verbose
Primary domain: child.ad.test
Subdomain: ad.test
```
This is because sssd is directly connected to the child.ad.test domain, but it internally
creates a domain structure (that we call subdomain in the code) to hold information about
the trusted domain, which in this case is not a subdomain, but a forest root and parent
domain of the primary domain. If SSSD was directly connected to the forest root, then the
internal subdomain structure would also be the actual subdomain, but the word subdomain in
the output would refer to the internal meaning.
In short, use the term 'Trusted domain' instead of 'Subdomain' in the
output. The 'Primary domain' is OK.
Again, sorry for jumping late to the review, hopefully you agree with the requested change
after reading the above explanation.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/285#issuecomment-306551157