URL: https://github.com/SSSD/sssd/pull/179 Author: jhrozek Title: #179: Search UPN only in the given domain Action: opened
PR body: """ We were searching UPNs in the whole sysdb, which made cache_req think the result came in from the domain it was searching.
The bug manifested when a user from a trusted domain was looked by UPN, then cache_req searched the main domain, the result from subdomain was considered as coming from the main domain and as a result, the getpwnam() output was not qualified. That is a problem, because PAM applications often sanitize the user with getpwnam, so effectively a login with UPN was shortened to just a shortname and failed. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/179/head:pr179 git checkout pr179
URL: https://github.com/SSSD/sssd/pull/179 Author: jhrozek Title: #179: Search UPN only in the given domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/179/head:pr179 git checkout pr179
URL: https://github.com/SSSD/sssd/pull/179 Author: jhrozek Title: #179: Search UPN only in the given domain Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/179/head:pr179 git checkout pr179
URL: https://github.com/SSSD/sssd/pull/179 Title: #179: Search UPN only in the given domain
jhrozek commented: """ retest this please """
See the full comment at https://github.com/SSSD/sssd/pull/179#issuecomment-283966849
URL: https://github.com/SSSD/sssd/pull/179 Title: #179: Search UPN only in the given domain
sumit-bose commented: """ Patches look good and are working as expected in my tests. ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/179#issuecomment-283968722
URL: https://github.com/SSSD/sssd/pull/179 Title: #179: Search UPN only in the given domain
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/179 Title: #179: Search UPN only in the given domain
jhrozek commented: """ * master: * 538321890c4d5f08c8702cfc2c00e57cbd13d334 * afadeb1a530ff010a2f9a7552562576b843c874b """
See the full comment at https://github.com/SSSD/sssd/pull/179#issuecomment-284048188
URL: https://github.com/SSSD/sssd/pull/179 Title: #179: Search UPN only in the given domain
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/179 Title: #179: Search UPN only in the given domain
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/179 Author: jhrozek Title: #179: Search UPN only in the given domain Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/179/head:pr179 git checkout pr179
URL: https://github.com/SSSD/sssd/pull/179 Title: #179: Search UPN only in the given domain
jhrozek commented: """ I also filed https://pagure.io/SSSD/sssd/issue/3319 to track removal of the option """
See the full comment at https://github.com/SSSD/sssd/pull/179#issuecomment-284049341
sssd-devel@lists.fedorahosted.org
-
jhrozek -
sumit-bose