This patch removes two unused variable warnings introduced in recent dbus patches.
On (13/05/14 21:42), Pavel Březina wrote:
This patch removes two unused variable warnings introduced in recent dbus patches.
I agree.
This variables were introduced in patch "SBUS: Refactor sbus_message_handler to retrieve caller ID" but this patch was not pushed yet.
From ad1c5582b716f06e2e71c0fd6e760bbf45a57bb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Fri, 9 May 2014 11:10:22 +0200 Subject: [PATCH 01/10] SBUS: remove unused variables
src/sbus/sssd_dbus_connection.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/src/sbus/sssd_dbus_connection.c b/src/sbus/sssd_dbus_connection.c index 72876ce3c7836edb35b1d8f5ea0c2365e11a668f..a136e7633fb0e08e4d44b95964884492cc8e2d0f 100644 --- a/src/sbus/sssd_dbus_connection.c +++ b/src/sbus/sssd_dbus_connection.c @@ -470,9 +470,7 @@ static void sbus_handler_got_caller_id(struct tevent_req *req) const struct sbus_method_meta *method; const struct sbus_interface_meta *interface; const char *msg_method;
- const char *path; const char *msg_interface;
- const char *sender; sbus_msg_handler_fn handler_fn = NULL; void *handler_data = NULL; /* Must be a talloc pointer! */ struct sbus_introspect_ctx *ictx = NULL;
@@ -489,9 +487,7 @@ static void sbus_handler_got_caller_id(struct tevent_req *req) }
msg_method = dbus_message_get_member(dbus_req->message);
path = dbus_message_get_path(dbus_req->message); msg_interface = dbus_message_get_interface(dbus_req->message);
sender = dbus_message_get_sender(dbus_req->message); DEBUG(SSSDBG_TRACE_ALL, "Received SBUS method [%s]\n", msg_method);
/* Prepare the handler */
LS
On Tue, May 13, 2014 at 09:55:45PM +0200, Lukas Slebodnik wrote:
On (13/05/14 21:42), Pavel Březina wrote:
This patch removes two unused variable warnings introduced in recent dbus patches.
I agree.
This variables were introduced in patch "SBUS: Refactor sbus_message_handler to retrieve caller ID" but this patch was not pushed yet.
Right, Pavel had this patch in his private branch, but I'd prefer to acknowledge that he found the issue and push separately.
ACK
On Tue, May 13, 2014 at 10:00:05PM +0200, Jakub Hrozek wrote:
On Tue, May 13, 2014 at 09:55:45PM +0200, Lukas Slebodnik wrote:
On (13/05/14 21:42), Pavel Březina wrote:
This patch removes two unused variable warnings introduced in recent dbus patches.
I agree.
This variables were introduced in patch "SBUS: Refactor sbus_message_handler to retrieve caller ID" but this patch was not pushed yet.
Right, Pavel had this patch in his private branch, but I'd prefer to acknowledge that he found the issue and push separately.
ACK
Pushed to master
On Tue, May 13, 2014 at 10:03:16PM +0200, Jakub Hrozek wrote:
On Tue, May 13, 2014 at 10:00:05PM +0200, Jakub Hrozek wrote:
On Tue, May 13, 2014 at 09:55:45PM +0200, Lukas Slebodnik wrote:
On (13/05/14 21:42), Pavel Březina wrote:
This patch removes two unused variable warnings introduced in recent dbus patches.
I agree.
This variables were introduced in patch "SBUS: Refactor sbus_message_handler to retrieve caller ID" but this patch was not pushed yet.
Right, Pavel had this patch in his private branch, but I'd prefer to acknowledge that he found the issue and push separately.
ACK
Pushed to master
Also pushed to sssd-1-11: 803434425e344019715f6c8ef98c8c929994bdf6
sssd-devel@lists.fedorahosted.org