On Mon, May 11, 2015 at 06:28:35PM +0200, Lukas Slebodnik wrote:
On (11/05/15 17:36), Pavel Reichl wrote:
>Rebased patch set is attached.
Code coverage of function pam_reply was quite high
but it covered just part which was necessary for Sumit's work.
I thought you would increase code coverage to all case you will change.
and not just rebase.
I would prefer to spend two hours with reviewing coverage of unit test
and then just check patches instead of checking all corner cases which
could be result of moving code from one function to another.
The function set_delayed_response is not covered at all.
and function add_warning_about_expiration covers very small potion of code.
NACK without unit tests.
I need these patches (or their variant, still a bit of WIP) to test the
PAM module properly, or rather to reuse the packing and unpacking.
Please let me know if they've changed substantially since the original
submission, but in the meantime I'll rebase and massage them in my
pwrap branch (I push it to fedorapeople git occasionally)..
We can see about test coverage when my PAM module tests and your PAM
responder tests materialize..