[PATCH] SSH: Do not print an error message if sss_ssh_authorizedkeys is asked for a local user
Hi,
please see the attached patch. I didn't find any information in the ssh man pages about the expected error codes from the AuthorizedKeysCommand, but I think we should at least suppress the error messages..
I tested with: $ sss_ssh_authorizedkeys root $ sss_ssh_authorizedkeys user-from-passwd $ sss_ssh_authorizedkeys user-from-ipa $ sss_ssh_authorizedkeys non-existing-user
The first three should be silent, the last one still prints an error message. I think that's acceptable, because I would expect ssh to call getpwnam() on its own before calling the AuthorizedKeysCommand.
On Thu, Apr 28, 2016 at 10:40:58AM +0200, Jakub Hrozek wrote:
Hi,
please see the attached patch. I didn't find any information in the ssh man pages about the expected error codes from the AuthorizedKeysCommand, but I think we should at least suppress the error messages..
I tested with: $ sss_ssh_authorizedkeys root $ sss_ssh_authorizedkeys user-from-passwd $ sss_ssh_authorizedkeys user-from-ipa $ sss_ssh_authorizedkeys non-existing-user
The first three should be silent, the last one still prints an error message. I think that's acceptable, because I would expect ssh to call getpwnam() on its own before calling the AuthorizedKeysCommand.
bump.
On 06/28/2016 06:45 PM, Jakub Hrozek wrote:
On Thu, Apr 28, 2016 at 10:40:58AM +0200, Jakub Hrozek wrote:
Hi,
please see the attached patch. I didn't find any information in the ssh man pages about the expected error codes from the AuthorizedKeysCommand, but I think we should at least suppress the error messages..
I tested with: $ sss_ssh_authorizedkeys root $ sss_ssh_authorizedkeys user-from-passwd $ sss_ssh_authorizedkeys user-from-ipa $ sss_ssh_authorizedkeys non-existing-user
The first three should be silent, the last one still prints an error message. I think that's acceptable, because I would expect ssh to call getpwnam() on its own before calling the AuthorizedKeysCommand.
bump.
Ack.
On (29/06/16 14:15), Pavel Březina wrote:
On 06/28/2016 06:45 PM, Jakub Hrozek wrote:
On Thu, Apr 28, 2016 at 10:40:58AM +0200, Jakub Hrozek wrote:
Hi,
please see the attached patch. I didn't find any information in the ssh man pages about the expected error codes from the AuthorizedKeysCommand, but I think we should at least suppress the error messages..
I tested with: $ sss_ssh_authorizedkeys root $ sss_ssh_authorizedkeys user-from-passwd $ sss_ssh_authorizedkeys user-from-ipa $ sss_ssh_authorizedkeys non-existing-user
The first three should be silent, the last one still prints an error message. I think that's acceptable, because I would expect ssh to call getpwnam() on its own before calling the AuthorizedKeysCommand.
bump.
Ack.
master: * fcbcfa69f9291936f01f24b5fcb5a7672dca46f3
LS
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Pavel Březina