On Tue, Nov 10, 2015 at 07:31:41AM +0100, Lukas Slebodnik wrote:
On (09/11/15 22:24), Jakub Hrozek wrote:
>From 42572bf05b14c959a938574059694dc04c87e7a1 Mon Sep 17 00:00:00 2001
>From: Jakub Hrozek <jhrozek(a)redhat.com>
>Date: Mon, 9 Nov 2015 22:12:05 +0100
>Subject: [PATCH] IFP: Skip non-POSIX groups properly
>When ifp_users_user_get_groups is called, for example via GetAll and
>the list of groups contains a non-POSIX group, we skip an array member,
>resulting in random memory being passed to the caller.
I do not plan to review the patch.
But please file a ticket to write an integration test for this bug.
btw this codepath would be visible in code coverage.
BTW this is exactly a reason why I prefered to focus on preparing
tests/test cases for IFP provider.
Unfortunately there is limited time. We can't retrospectively write tests
I'm even struggling to finish the authentication tests, we must already
refocus to work on bugs and also new features for the next release..
(These new features should be either tested or at the very least written
such that testing is possible (also focus on nice modularity))