URL:
https://github.com/SSSD/sssd/pull/5356
Title: #5356: krb5_child: Harden credentials validation code
sumit-bose commented:
"""
> Hi,
> thanks for the patch, it looks good. I just wonder if it might be risky to use the
pretty generic macro `TRUE` which other libraries we might include as well may define
completely different? With a quick grep in /usr/include I didn't found an example but
even in the MIT krb5 source code `1`is used in `krb_auth_su.c`.
TRUE is defined in /usr/include/krb5/krb5.h but I can change the code to just use
'1' if you think this is too risky.
Hi,
my point is that it is not only defined there but in other headers as well, `grep -r
'define TRUE ' /usr/include/*` finds 16 files on my system. However, most of them
are `1` and from looking at the MIT source code it would be only an issue if the value
would be `0` which would really an unusual definition for `TRUE`. Finally `#define TRUE 1`
is part of the LSB
(
http://refspecs.linux-foundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-...),
so ACK.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5356#issuecomment-705339532