Without this patch I can't build SSSD for rawhide as new autoconf versions error out when $(srcdir) is used in TESTS:
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/config/SSSDConfigTest.py' parallel-tests: installing 'build/test-driver' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pyhbac-test.py' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pysss_murmur-test.py'
Not using srcdir is OK as the GNU manual states: "Automake ensures that each file listed in TESTS is built before it is run; you can list both source and derived programs (or scripts) in TESTS; the generated rule will look both in srcdir and .."
This is an excerpt from: http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
Without this patch I can't build SSSD for rawhide as new autoconf versions error out when $(srcdir) is used in TESTS:
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/config/SSSDConfigTest.py' parallel-tests: installing 'build/test-driver' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pyhbac-test.py' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pysss_murmur-test.py'
Not using srcdir is OK as the GNU manual states: "Automake ensures that each file listed in TESTS is built before it is run; you can list both source and derived programs (or scripts) in TESTS; the generated rule will look both in srcdir and .."
This is an excerpt from: http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-...
Can you check this against older versions of automake? I feel fairly confident that this was an issue on Automake 1.9 and older.
On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
Without this patch I can't build SSSD for rawhide as new autoconf versions error out when $(srcdir) is used in TESTS:
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/config/SSSDConfigTest.py' parallel-tests: installing 'build/test-driver' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pyhbac-test.py' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pysss_murmur-test.py'
Not using srcdir is OK as the GNU manual states: "Automake ensures that each file listed in TESTS is built before it is run; you can list both source and derived programs (or scripts) in TESTS; the generated rule will look both in srcdir and .."
This is an excerpt from: http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-...
Can you check this against older versions of automake? I feel fairly confident that this was an issue on Automake 1.9 and older.
I was able to run "autoreconf -if; configure; make; make check" on both RHEL5 and RHEL6 with this patch.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
Without this patch I can't build SSSD for rawhide as new autoconf versions error out when $(srcdir) is used in TESTS:
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/config/SSSDConfigTest.py' parallel-tests: installing 'build/test-driver' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pyhbac-test.py' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pysss_murmur-test.py'
Not using srcdir is OK as the GNU manual states: "Automake ensures that each file listed in TESTS is built before it is run; you can list both source and derived programs (or scripts) in TESTS; the generated rule will look both in srcdir and .."
This is an excerpt from: http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-...
Can you check this against older versions of automake? I feel fairly confident that this was an issue on Automake 1.9 and older.
I was able to run "autoreconf -if; configure; make; make check" on both RHEL5 and RHEL6 with this patch.
Ok, ack
On Fri, Feb 01, 2013 at 08:39:10AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
Without this patch I can't build SSSD for rawhide as new autoconf versions error out when $(srcdir) is used in TESTS:
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/config/SSSDConfigTest.py' parallel-tests: installing 'build/test-driver' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pyhbac-test.py' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pysss_murmur-test.py'
Not using srcdir is OK as the GNU manual states: "Automake ensures that each file listed in TESTS is built before it is run; you can list both source and derived programs (or scripts) in TESTS; the generated rule will look both in srcdir and .."
This is an excerpt from: http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-...
Can you check this against older versions of automake? I feel fairly confident that this was an issue on Automake 1.9 and older.
I was able to run "autoreconf -if; configure; make; make check" on both RHEL5 and RHEL6 with this patch.
Ok, ack
Pushed to master and sssd-1-9
On Mon, Feb 04, 2013 at 04:34:16PM +0100, Jakub Hrozek wrote:
On Fri, Feb 01, 2013 at 08:39:10AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
Without this patch I can't build SSSD for rawhide as new autoconf versions error out when $(srcdir) is used in TESTS:
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/config/SSSDConfigTest.py' parallel-tests: installing 'build/test-driver' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pyhbac-test.py' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pysss_murmur-test.py'
Not using srcdir is OK as the GNU manual states: "Automake ensures that each file listed in TESTS is built before it is run; you can list both source and derived programs (or scripts) in TESTS; the generated rule will look both in srcdir and .."
This is an excerpt from: http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-...
Can you check this against older versions of automake? I feel fairly confident that this was an issue on Automake 1.9 and older.
I was able to run "autoreconf -if; configure; make; make check" on both RHEL5 and RHEL6 with this patch.
Ok, ack
Pushed to master and sssd-1-9
I would like to also push this patch to sssd-1-5. Currently sssd-1-5 can't be even configured with recent Fedora toolchain.
On (20/06/13 10:21), Jakub Hrozek wrote:
On Mon, Feb 04, 2013 at 04:34:16PM +0100, Jakub Hrozek wrote:
On Fri, Feb 01, 2013 at 08:39:10AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
Without this patch I can't build SSSD for rawhide as new autoconf versions error out when $(srcdir) is used in TESTS:
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/config/SSSDConfigTest.py' parallel-tests: installing 'build/test-driver' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pyhbac-test.py' Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/src/tests/pysss_murmur-test.py'
Not using srcdir is OK as the GNU manual states: "Automake ensures that each file listed in TESTS is built before it is run; you can list both source and derived programs (or scripts) in TESTS; the generated rule will look both in srcdir and .."
This is an excerpt from: http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-...
Can you check this against older versions of automake? I feel fairly confident that this was an issue on Automake 1.9 and older.
I was able to run "autoreconf -if; configure; make; make check" on both RHEL5 and RHEL6 with this patch.
Ok, ack
Pushed to master and sssd-1-9
I would like to also push this patch to sssd-1-5. Currently sssd-1-5 can't be even configured with recent Fedora toolchain.
If you want to apply commit fa551077410019fb34460dc730950e93b62b2963, there will be small conflict.
After resolving conflict, compilation works well with rhel5 and fedora19.
LS
on Thu, Jun 20, 2013 at 01:01:54PM +0200, Lukas Slebodnik wrote:
On (20/06/13 10:21), Jakub Hrozek wrote:
On Mon, Feb 04, 2013 at 04:34:16PM +0100, Jakub Hrozek wrote:
On Fri, Feb 01, 2013 at 08:39:10AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote: > Without this patch I can't build SSSD for rawhide as new autoconf > versions error out when $(srcdir) is used in TESTS: > > Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: > '$(srcdir)/src/config/SSSDConfigTest.py' > parallel-tests: installing 'build/test-driver' > Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: > '$(srcdir)/src/tests/pyhbac-test.py' > Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: > '$(srcdir)/src/tests/pysss_murmur-test.py' > > > Not using srcdir is OK as the GNU manual states: > "Automake ensures that each file listed in TESTS is built before it is > run; you can list both source and derived programs (or scripts) in > TESTS; the generated rule will look both in srcdir and .." > > This is an excerpt from: > http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-... >
Can you check this against older versions of automake? I feel fairly confident that this was an issue on Automake 1.9 and older.
I was able to run "autoreconf -if; configure; make; make check" on both RHEL5 and RHEL6 with this patch.
Ok, ack
Pushed to master and sssd-1-9
I would like to also push this patch to sssd-1-5. Currently sssd-1-5 can't be even configured with recent Fedora toolchain.
If you want to apply commit fa551077410019fb34460dc730950e93b62b2963, there will be small conflict.
After resolving conflict, compilation works well with rhel5 and fedora19.
LS
Ah, I meant to forgot to attach the patch that applies on sssd-1-5. Here it is.
On (20/06/13 13:45), Jakub Hrozek wrote:
on Thu, Jun 20, 2013 at 01:01:54PM +0200, Lukas Slebodnik wrote:
On (20/06/13 10:21), Jakub Hrozek wrote:
On Mon, Feb 04, 2013 at 04:34:16PM +0100, Jakub Hrozek wrote:
On Fri, Feb 01, 2013 at 08:39:10AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote: >> Without this patch I can't build SSSD for rawhide as new autoconf >> versions error out when $(srcdir) is used in TESTS: >> >> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: >> '$(srcdir)/src/config/SSSDConfigTest.py' >> parallel-tests: installing 'build/test-driver' >> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: >> '$(srcdir)/src/tests/pyhbac-test.py' >> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: >> '$(srcdir)/src/tests/pysss_murmur-test.py' >> >> >> Not using srcdir is OK as the GNU manual states: >> "Automake ensures that each file listed in TESTS is built before it is >> run; you can list both source and derived programs (or scripts) in >> TESTS; the generated rule will look both in srcdir and .." >> >> This is an excerpt from: >> http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-... >> > > Can you check this against older versions of automake? I feel fairly > confident that this was an issue on Automake 1.9 and older.
I was able to run "autoreconf -if; configure; make; make check" on both RHEL5 and RHEL6 with this patch.
Ok, ack
Pushed to master and sssd-1-9
I would like to also push this patch to sssd-1-5. Currently sssd-1-5 can't be even configured with recent Fedora toolchain.
If you want to apply commit fa551077410019fb34460dc730950e93b62b2963, there will be small conflict.
After resolving conflict, compilation works well with rhel5 and fedora19.
LS
Ah, I meant to forgot to attach the patch that applies on sssd-1-5. Here it is.
From aaf0f8071f48d79424aa7517f4b95078d3cd00bd Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Thu, 31 Jan 2013 18:52:08 +0100 Subject: [PATCH] Don't use srcdir with tests
Fixes build with automake 1.13 or newer.
Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am index 42ef8e0fa628ac5e1d07ff8d4fb6800c4c59a2eb..fc5595e6c0f57444c9b1b865626c24b953d8f3f1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -100,8 +100,8 @@ check_PROGRAMS = \ PYTHON_TESTS =
if BUILD_PYTHON_BINDINGS -PYTHON_TESTS += $(srcdir)/src/config/SSSDConfigTest.py \
$(srcdir)/src/tests/pyhbac-test.py
+PYTHON_TESTS += src/config/SSSDConfigTest.py \
src/tests/pyhbac-test.py
endif
TESTS = \
1.8.2.1
ACK
LS
On Thu, Jun 20, 2013 at 06:40:30PM +0200, Lukas Slebodnik wrote:
On (20/06/13 13:45), Jakub Hrozek wrote:
on Thu, Jun 20, 2013 at 01:01:54PM +0200, Lukas Slebodnik wrote:
On (20/06/13 10:21), Jakub Hrozek wrote:
On Mon, Feb 04, 2013 at 04:34:16PM +0100, Jakub Hrozek wrote:
On Fri, Feb 01, 2013 at 08:39:10AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote: > On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote: >>> Without this patch I can't build SSSD for rawhide as new autoconf >>> versions error out when $(srcdir) is used in TESTS: >>> >>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: >>> '$(srcdir)/src/config/SSSDConfigTest.py' >>> parallel-tests: installing 'build/test-driver' >>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: >>> '$(srcdir)/src/tests/pyhbac-test.py' >>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken: >>> '$(srcdir)/src/tests/pysss_murmur-test.py' >>> >>> >>> Not using srcdir is OK as the GNU manual states: >>> "Automake ensures that each file listed in TESTS is built before it is >>> run; you can list both source and derived programs (or scripts) in >>> TESTS; the generated rule will look both in srcdir and .." >>> >>> This is an excerpt from: >>> http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-... >>> >> >> Can you check this against older versions of automake? I feel fairly >> confident that this was an issue on Automake 1.9 and older. > > I was able to run "autoreconf -if; configure; make; make check" on both > RHEL5 and RHEL6 with this patch.
Ok, ack
Pushed to master and sssd-1-9
I would like to also push this patch to sssd-1-5. Currently sssd-1-5 can't be even configured with recent Fedora toolchain.
If you want to apply commit fa551077410019fb34460dc730950e93b62b2963, there will be small conflict.
After resolving conflict, compilation works well with rhel5 and fedora19.
LS
Ah, I meant to forgot to attach the patch that applies on sssd-1-5. Here it is.
From aaf0f8071f48d79424aa7517f4b95078d3cd00bd Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Thu, 31 Jan 2013 18:52:08 +0100 Subject: [PATCH] Don't use srcdir with tests
Fixes build with automake 1.13 or newer.
Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am index 42ef8e0fa628ac5e1d07ff8d4fb6800c4c59a2eb..fc5595e6c0f57444c9b1b865626c24b953d8f3f1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -100,8 +100,8 @@ check_PROGRAMS = \ PYTHON_TESTS =
if BUILD_PYTHON_BINDINGS -PYTHON_TESTS += $(srcdir)/src/config/SSSDConfigTest.py \
$(srcdir)/src/tests/pyhbac-test.py
+PYTHON_TESTS += src/config/SSSDConfigTest.py \
src/tests/pyhbac-test.py
endif
TESTS = \
1.8.2.1
ACK
LS
Pushed to sssd-1-5
sssd-devel@lists.fedorahosted.org