On (25/07/16 17:44), Sumit Bose wrote:
Hi,
this patch fixes and issue which was reported by Coverity. The fix was
originally proposed by Lukas but he preferred that I send the patch.
bye,
Sumit
From d081be21235425b9137ddb22941245f5677ca54a Mon Sep 17 00:00:00
2001
From: Sumit Bose <sbose(a)redhat.com>
Date: Mon, 25 Jul 2016 17:37:51 +0200
Subject: [PATCH] sysdb_master_domain_add_info: properly set do_update
do_update should be only set if there is a change, i.e if something was
added to the ldb_message.
---
src/db/sysdb_subdomains.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/db/sysdb_subdomains.c b/src/db/sysdb_subdomains.c
index 02206e470e8e035cc05848137df6a1eb04806869..ff83f914f31d566e050c74a3ef5f5745f8c93add
100644
--- a/src/db/sysdb_subdomains.c
+++ b/src/db/sysdb_subdomains.c
@@ -787,9 +787,9 @@ errno_t sysdb_master_domain_add_info(struct sss_domain_info *domain,
ret = sysdb_error_to_errno(ret);
goto done;
}
- }
- do_update = true;
+ do_update = true;
+ }
}
if (do_update == false) {
ACK
http://sssd-ci.duckdns.org/logs/job/50/16/summary.html
LS