On Tue, Jan 19, 2016 at 03:02:10PM +0100, Michal Židek wrote:
On 01/19/2016 01:38 PM, Pavel Březina wrote:
>https://fedorahosted.org/sssd/ticket/2904
>
>Unfortunately, I wasn't able to reproduce the issue and neither the
>reporter can reproduce it anymore and we can't known exactly why we get
>to situation when uri and sockaddr is NULL without the logs.
>
>service->uri and service->sockaddr are assigned through failover
>callback, see ad_resolve_callback for example, which is probably used in
>the reporter's environment. My suspicion is that for some reason we
>can't assign those attributes (which may happen for several reasons) but
>since failover callback doesn't report any error failover actually
>succeeds and we end up dereferencing NULL.
>
>I don't think we can move any further without logs but this is at least
>a hotfix that will prevent segfault.
>
As additional hardening, the patch LGTM.
CI passed:
sssd-ci.duckdns.org/logs/job/35/73/summary.html
ACK.
Michal
Pushed upstream:
* master: 8bd9ec3a8885b01a34863d22aa784e221fc422fb
* sssd-1-13: b32ea7b1f91b4194e05a1a965310691075ecba23