URL:
https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config
alexey-tikhonov commented:
"""
Nitpick:
IMO, it would be slightly better performance-wise to simply move
```
if (!order) {
DEBUG(SSSDBG_CRIT_FAILURE, "The SELinux order is missing\n");
return EINVAL;
}
```
above `attrs = talloc_zero` thus avoiding redundant alloc/free in case of missing
`order`.
But patch "as is" obviously fixes memleak. So if you do not want to address this
remark then ACK and feel free to push this.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/897#issuecomment-541085121