On Thu, 10 Jun 2010 20:34:13 +0200
Jakub Hrozek <jhrozek(a)redhat.com> wrote:
+#define SSSD_KRB5_CHANGEPW_PRINCIPLE "SSSD_KRB5_CHANGEPW_PRINCIPLE"
+
shouldn't this be: "kadmin/changepw" ?
struct krb5_child_ctx {
/* opts taken from kinit */
/* in seconds */
@@ -63,7 +65,6 @@ struct krb5_child_ctx {
char *kdcip;
char *realm;
- char *changepw_principle;
char *ccache_dir;
char *ccname_template;
int auth_timeout;
@@ -587,9 +588,9 @@ static errno_t changepw_child(int fd, struct
krb5_req *kr) }
kerr = krb5_get_init_creds_password(kr->ctx, kr->creds,
kr->princ,
- pass_str, prompter, kr, 0,
-
kr->krb5_ctx->changepw_principle,
- kr->options);
+ pass_str, prompter, kr, 0,
+ discard_const_p(char,
SSSD_KRB5_CHANGEPW_PRINCIPLE),
+ kr->options);
I really don't like the use of discard_const_p(), can you please
talloc_strdup() it ?
Simo.
--
Simo Sorce * Red Hat, Inc * New York