-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/22/2010 12:19 PM, Jakub Hrozek wrote:
On 02/22/2010 05:34 PM, Stephen Gallagher wrote:
> Simo noticed a typo on this patch during code review. Fixed.
* providers/data_provider.h:67 still mentions "domains" in the PAM
response packet
Fixed
* I'm not sure about removing pd->domain from
pam_print_data(). It is
still used elsewhere in the code (via the DEBUG_PAM_DATA() macro)
Ah, thanks. I removed that because I was originally going to remove
pd->domain from the pam_ctx struct, but I decided to leave it around. I
forgot to put it back into pam_print_data().
Otherwise looks good to me.
New patch attached.
Ack to the other (DP registration) patch.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkuCv0AACgkQeiVVYja6o6OI9gCdES4LpP+zsVOJOPdLaD4qUaRe
NbsAn3gvThQYCR4cGX/VUgKSsUN13OjZ
=+J1z
-----END PGP SIGNATURE-----