URL: https://github.com/SSSD/sssd/pull/541 Author: pbrezina Title: #541: memberof: keep memberOf attribute for nested member Action: opened
PR body: """ If we have a member that is both direct and nested member, memberOf attribute was removed if the direct membership was deleted.
1) user ----------> groupB -> groupC -> groupA /
2) user -> groupA -> groupB -> groupC
If we remove user->groupB from 1), we get 2) but groupB was still removed from user memberOf attribute.
Resolves: https://pagure.io/SSSD/sssd/issue/3636 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/541/head:pr541 git checkout pr541
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
pbrezina commented: """ Do we have any memberof plugin unit or integration tests that I can amend? I did not find any... """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-374188150
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
pbrezina commented: """ Please, review carefully. This fixed the issue and I did not run into any troubles with this patch, however I'm not sure if this check was only "just in case this happens but we should never get here" or it is actually used to do something meaningful. """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-374188533
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
jhrozek commented: """ yes, in the sysdb tests (the old check-based one, not under the cmocka/ folder) """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-374189153
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
pbrezina commented: """ I gave a scratch build to users and the confirmed that the patch fix their issue. """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-381879720
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
sumit-bose commented: """ @pbrezina, have you checked if you have only 1.
user -> groupB -> groupC -> groupA
That the memberships to groupC and groupA are removed properly as well if the membership to groupB is removed form the user?
And second that the memberships to groupC and groupA are remove if you remove groupC from groupB but keep the user a member of groupB?
The comment in the removed code sounds a bit like one of those cases.
Another test case might be
user -> groupB -> groupC -> groupA |-> groupA (groupA is direct and indirect member of groupB and should be kept for user if groupC is removed from groupB) """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-381891583
URL: https://github.com/SSSD/sssd/pull/541 Author: pbrezina Title: #541: memberof: keep memberOf attribute for nested member Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/541/head:pr541 git checkout pr541
URL: https://github.com/SSSD/sssd/pull/541 Author: pbrezina Title: #541: memberof: keep memberOf attribute for nested member Action: reopened
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/541/head:pr541 git checkout pr541
URL: https://github.com/SSSD/sssd/pull/541 Author: pbrezina Title: #541: memberof: keep memberOf attribute for nested member Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/541/head:pr541 git checkout pr541
URL: https://github.com/SSSD/sssd/pull/541 Author: pbrezina Title: #541: memberof: keep memberOf attribute for nested member Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/541/head:pr541 git checkout pr541
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
pbrezina commented: """ Sorry, this patch got stalled. I rebased it on top of current master.
All cases mentioned by @sumit-bose works correctly with this patch. I have not found any problem and the users confirmed that it works a year ago :-) """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-478920065
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
sumit-bose commented: """ ACK.
Btw, after some digging I found that the code block you just removed was added to fix https://pagure.io/SSSD/sssd/issue/400. I guess this issue is specific for the local provider since of other provider SSSD does not have to manage the nested group hierarchy but just gets it from the external source. And since the local provider is not supported anymore this issue is gone as well.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-479838694
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
pbrezina commented: """ Great! Thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-479852411
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
jhrozek commented: """ * master: 1f5d139d103328b6e4be7dc8368abdd39a91d3a6 """
See the full comment at https://github.com/SSSD/sssd/pull/541#issuecomment-481003396
URL: https://github.com/SSSD/sssd/pull/541 Author: pbrezina Title: #541: memberof: keep memberOf attribute for nested member Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/541/head:pr541 git checkout pr541
URL: https://github.com/SSSD/sssd/pull/541 Title: #541: memberof: keep memberOf attribute for nested member
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
jhrozek -
pbrezina
-
sumit-bose