On Mon, Nov 26, 2012 at 04:01:03PM -0500, Simo Sorce wrote:
On Mon, 2012-11-26 at 21:26 +0100, Jakub Hrozek wrote:
> On Mon, Nov 26, 2012 at 09:52:13AM -0500, Simo Sorce wrote:
> > On Sun, 2012-11-25 at 23:53 +0100, Jakub Hrozek wrote:
> > > I'm implementing unit tests for the ghosts users feature to make sure
we
> > > catch all the problems for the next upstream release. Attached is a
> > > patch with a couple of unit tests that simulate what the LDAP provider
> > > would do when using the RFC2307 schema.
> > >
> > > Suggestions for new tests are welcome. Please note that the mod
> > > operation inside the memberof plugin will be implemented as part of
> > > #1652, so any tests that modify the ghost users attribute (as opposed to
> > > add or delete) won't work at the moment.
> >
> > As discussed on IRC, a few comments and a minor change are due, so
> > waiting for a new version.
> >
> > Simo.
>
> The second iteration of the patch brings comments and a more descriptive macros
> to illustrate several non-obvious parts of the test.
ACK.
Simo.
Pushed to master and sssd-1-9
I pushed to sssd-1-9 as well b/c we will be touching the related areas
of code there with additional patches and I'd like to know if something
broke later with a patch that diverged from master.