-----BEGIN PGP SIGNED MESSAGE-----
On 09/18/2009 08:57 PM, Dmitri Pal wrote:
After reflecting on the matter a bit (while Steven was holding the
mirror) I suggest a Nack.
There are other places that need to be looked at.
./providers/file/file_fmt_csv.c: cfg = (struct file_csv_cfg
OK, I spotted this one before and thought we didn't need a calloc b/c
all the structure members are initialized later on. But I guess it can't
hurt, esp. when extending the structure.
./elapi_log.c: handle = (struct elapi_dispatcher *)
Done. We did a malloc&memset, but calloc is cleaner solution I guess
Please use grep malloc across the whole elapi tree and check if I missed
done, only string allocation and similar.
New patch is attached,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----