ehlo,
Samba 4 libraries are necessary for building {ad, ipa} provider, but samba4 needn't be available on older distributions. This patch add possibility to build SSSD without {ad, ipa} provider and thus without Samba 4 libraries. The script configure have new argument --with-samba with default value yes.
How to test this patch on fedora >=19 ? --remove package samba-devel --run configure script with argument "--with-samba"
The other option is to build srpm with mock/koji with small change in spec. --sssd should be build without libsss_{ipa,ad}.so and pac plugin --all test shoudl pass --there will be error athe end of mock build with RPM build errors: File not found: ....
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index 9292451..88f5994 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@ -126,11 +126,6 @@ BuildRequires: libnl3-devel BuildRequires: libnl-devel %endif
-# RHEL 5 is too old to support samba4 and the PAC responder -%if !0%{?is_rhel5} -BuildRequires: samba4-devel -%endif - %description Provides a set of daemons to manage access to remote directories and authentication mechanisms. It provides an NSS and PAM interface toward @@ -402,6 +397,7 @@ autoreconf -ivf --with-pipe-path=%{pipepath} \ --with-pubconf-path=%{pubconfpath} \ --with-init-dir=%{_initrddir} \ + --without-samba \ --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \ --enable-nsslibdir=/%{_lib} \ --enable-pammoddir=/%{_lib}/security \
Attached are patches for master and 1.11 branch. There was conflict in conf_macros.m4 and configure.ac
LS
On 05/08/2014 11:12 PM, Lukas Slebodnik wrote:
ehlo,
Samba 4 libraries are necessary for building {ad, ipa} provider, but samba4 needn't be available on older distributions. This patch add possibility to build SSSD without {ad, ipa} provider and thus without Samba 4 libraries. The script configure have new argument --with-samba with default value yes.
How to test this patch on fedora >=19 ? --remove package samba-devel --run configure script with argument "--with-samba"
The other option is to build srpm with mock/koji with small change in spec. --sssd should be build without libsss_{ipa,ad}.so and pac plugin --all test shoudl pass --there will be error athe end of mock build with RPM build errors: File not found: ....
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index 9292451..88f5994 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@ -126,11 +126,6 @@ BuildRequires: libnl3-devel BuildRequires: libnl-devel %endif
-# RHEL 5 is too old to support samba4 and the PAC responder -%if !0%{?is_rhel5} -BuildRequires: samba4-devel -%endif
- %description Provides a set of daemons to manage access to remote directories and authentication mechanisms. It provides an NSS and PAM interface toward
@@ -402,6 +397,7 @@ autoreconf -ivf --with-pipe-path=%{pipepath} \ --with-pubconf-path=%{pubconfpath} \ --with-init-dir=%{_initrddir} \
- --without-samba \ --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \ --enable-nsslibdir=/%{_lib} \ --enable-pammoddir=/%{_lib}/security \
Attached are patches for master and 1.11 branch. There was conflict in conf_macros.m4 and configure.ac
LS
Hi Lukas,
almost :)
Your patch works (worked) good, but some changes were done in the Makefile.am since the time you sent the patches.
Add these 2 lines to Makefile.am
+if BUILD_SAMBA pkglib_LTLIBRARIES += libsss_ad_common.la +endif
Michal
On 05/15/2014 06:10 PM, Michal Židek wrote:
On 05/08/2014 11:12 PM, Lukas Slebodnik wrote:
ehlo,
Samba 4 libraries are necessary for building {ad, ipa} provider, but samba4 needn't be available on older distributions. This patch add possibility to build SSSD without {ad, ipa} provider and thus without Samba 4 libraries. The script configure have new argument --with-samba with default value yes.
How to test this patch on fedora >=19 ? --remove package samba-devel --run configure script with argument "--with-samba"
The other option is to build srpm with mock/koji with small change in spec. --sssd should be build without libsss_{ipa,ad}.so and pac plugin --all test shoudl pass --there will be error athe end of mock build with RPM build errors: File not found: ....
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index 9292451..88f5994 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@ -126,11 +126,6 @@ BuildRequires: libnl3-devel BuildRequires: libnl-devel %endif
-# RHEL 5 is too old to support samba4 and the PAC responder -%if !0%{?is_rhel5} -BuildRequires: samba4-devel -%endif
- %description Provides a set of daemons to manage access to remote directories and authentication mechanisms. It provides an NSS and PAM interface toward
@@ -402,6 +397,7 @@ autoreconf -ivf --with-pipe-path=%{pipepath} \ --with-pubconf-path=%{pubconfpath} \ --with-init-dir=%{_initrddir} \
- --without-samba \ --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \ --enable-nsslibdir=/%{_lib} \ --enable-pammoddir=/%{_lib}/security \
Attached are patches for master and 1.11 branch. There was conflict in conf_macros.m4 and configure.ac
LS
Hi Lukas,
almost :)
Your patch works (worked) good, but some changes were done in the Makefile.am since the time you sent the patches.
Add these 2 lines to Makefile.am
+if BUILD_SAMBA pkglib_LTLIBRARIES += libsss_ad_common.la +endif
Michal
I forgot to say, that the patch for 1.11 is OK, so ACK for 1.11.
And as you already know, there are some test that need to be build conditionally as well (I did not noticed this first, because I did not run make check when the make already failed).
Michal
On (15/05/14 18:48), Michal Židek wrote:
On 05/15/2014 06:10 PM, Michal Židek wrote:
On 05/08/2014 11:12 PM, Lukas Slebodnik wrote:
ehlo,
Samba 4 libraries are necessary for building {ad, ipa} provider, but samba4 needn't be available on older distributions. This patch add possibility to build SSSD without {ad, ipa} provider and thus without Samba 4 libraries. The script configure have new argument --with-samba with default value yes.
How to test this patch on fedora >=19 ? --remove package samba-devel --run configure script with argument "--with-samba"
The other option is to build srpm with mock/koji with small change in spec. --sssd should be build without libsss_{ipa,ad}.so and pac plugin --all test shoudl pass --there will be error athe end of mock build with RPM build errors: File not found: ....
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index 9292451..88f5994 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@ -126,11 +126,6 @@ BuildRequires: libnl3-devel BuildRequires: libnl-devel %endif
-# RHEL 5 is too old to support samba4 and the PAC responder -%if !0%{?is_rhel5} -BuildRequires: samba4-devel -%endif
%description Provides a set of daemons to manage access to remote directories and authentication mechanisms. It provides an NSS and PAM interface toward @@ -402,6 +397,7 @@ autoreconf -ivf --with-pipe-path=%{pipepath} \ --with-pubconf-path=%{pubconfpath} \ --with-init-dir=%{_initrddir} \
- --without-samba \ --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \ --enable-nsslibdir=/%{_lib} \ --enable-pammoddir=/%{_lib}/security \
Attached are patches for master and 1.11 branch. There was conflict in conf_macros.m4 and configure.ac
LS
Hi Lukas,
almost :)
Your patch works (worked) good, but some changes were done in the Makefile.am since the time you sent the patches.
Add these 2 lines to Makefile.am
+if BUILD_SAMBA pkglib_LTLIBRARIES += libsss_ad_common.la +endif
Michal
I forgot to say, that the patch for 1.11 is OK, so ACK for 1.11.
And as you already know, there are some test that need to be build conditionally as well (I did not noticed this first, because I did not run make check when the make already failed).
Michal
Thank you for review. The patch for master was sent to review few days ago and meantime gpo patch was pushed to master.
Updated patches are attached.
LS
On 05/15/2014 08:51 PM, Lukas Slebodnik wrote:
On (15/05/14 18:48), Michal Židek wrote:
On 05/15/2014 06:10 PM, Michal Židek wrote:
On 05/08/2014 11:12 PM, Lukas Slebodnik wrote:
ehlo,
Samba 4 libraries are necessary for building {ad, ipa} provider, but samba4 needn't be available on older distributions. This patch add possibility to build SSSD without {ad, ipa} provider and thus without Samba 4 libraries. The script configure have new argument --with-samba with default value yes.
How to test this patch on fedora >=19 ? --remove package samba-devel --run configure script with argument "--with-samba"
The other option is to build srpm with mock/koji with small change in spec. --sssd should be build without libsss_{ipa,ad}.so and pac plugin --all test shoudl pass --there will be error athe end of mock build with RPM build errors: File not found: ....
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index 9292451..88f5994 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@ -126,11 +126,6 @@ BuildRequires: libnl3-devel BuildRequires: libnl-devel %endif
-# RHEL 5 is too old to support samba4 and the PAC responder -%if !0%{?is_rhel5} -BuildRequires: samba4-devel -%endif
- %description Provides a set of daemons to manage access to remote directories and authentication mechanisms. It provides an NSS and PAM interface toward
@@ -402,6 +397,7 @@ autoreconf -ivf --with-pipe-path=%{pipepath} \ --with-pubconf-path=%{pubconfpath} \ --with-init-dir=%{_initrddir} \
- --without-samba \ --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \ --enable-nsslibdir=/%{_lib} \ --enable-pammoddir=/%{_lib}/security \
Attached are patches for master and 1.11 branch. There was conflict in conf_macros.m4 and configure.ac
LS
Hi Lukas,
almost :)
Your patch works (worked) good, but some changes were done in the Makefile.am since the time you sent the patches.
Add these 2 lines to Makefile.am
+if BUILD_SAMBA pkglib_LTLIBRARIES += libsss_ad_common.la +endif
Michal
I forgot to say, that the patch for 1.11 is OK, so ACK for 1.11.
And as you already know, there are some test that need to be build conditionally as well (I did not noticed this first, because I did not run make check when the make already failed).
Michal
Thank you for review. The patch for master was sent to review few days ago and meantime gpo patch was pushed to master.
Updated patches are attached.
LS
Patch for 1.11: ACK. Patch for master: ACK.
Michal
On Fri, May 16, 2014 at 02:54:16PM +0200, Michal Židek wrote:
Thank you for review. The patch for master was sent to review few days ago and meantime gpo patch was pushed to master.
Updated patches are attached.
LS
Patch for 1.11: ACK. Patch for master: ACK.
Michal
Pushed to master: a2e417f38c57ed87c956ddcecf4dafca93842b65 and sssd-1-11: d1da6541423bcb0e587939945572d29060d0b6a0
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Michal Židek