URL: https://github.com/SSSD/sssd/pull/233 Author: mzidek-rh Title: #233: SDAP: Fix handling of search bases Action: opened
PR body: """ We were rewriting the sdap_domain's search bases for only the first sdap_domain in the list, which does not work for subdomains.
Also when search bases were already initialized in sdap_domain_subdom_add, we should only rewrite them when they were explicitly set in sssd.conf.
Resolves: https://pagure.io/SSSD/sssd/issue/3351 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/233/head:pr233 git checkout pr233
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
jhrozek commented: """ nack, I'm getting a valgrind error with this patch: ``` ==31975== Conditional jump or move depends on uninitialised value(s) ==31975== at 0xDB1543E: ad_set_search_bases (ad_common.c:1153) ==31975== by 0xDAF65FA: ipa_ad_ctx_new (ipa_subdomains_server.c:335) ==31975== by 0xDAF8417: ipa_server_create_trusts_ctx (ipa_subdomains_server.c:946) ==31975== by 0xDAF8343: ipa_server_create_trusts_done (ipa_subdomains_server.c:919) ==31975== by 0xDAF8005: ipa_server_trust_1way_kt_done (ipa_subdomains_server.c:810) ==31975== by 0xDAF6F5E: ipa_getkeytab_done (ipa_subdomains_server.c:537) ==31975== by 0x73E333D: child_invoke_callback (child_common.c:604) ==31975== by 0x9247703: tevent_common_loop_immediate (in /usr/lib64/libtevent.so.0.9.31) ==31975== by 0x924C98C: ??? (in /usr/lib64/libtevent.so.0.9.31) ==31975== by 0x924AF76: ??? (in /usr/lib64/libtevent.so.0.9.31) ==31975== by 0x9246D3C: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.31) ==31975== by 0x9246F6A: tevent_common_loop_wait (in /usr/lib64/libtevent.so.0.9.31) ==31975== ```
You need to initialize `default_search_base`... """
See the full comment at https://github.com/SSSD/sssd/pull/233#issuecomment-295786534
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/233 Author: mzidek-rh Title: #233: SDAP: Fix handling of search bases Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/233/head:pr233 git checkout pr233
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
mzidek-rh commented: """ Updated patch pushed. """
See the full comment at https://github.com/SSSD/sssd/pull/233#issuecomment-295791320
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
jhrozek commented: """ Thank you.
We spent some time today with Michal debugging upstream ticket #3381 and now I'm confident that a) this patch works and b) it is not related to upstream #3381.
ACK """
See the full comment at https://github.com/SSSD/sssd/pull/233#issuecomment-297988926
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
lslebodn commented: """ master: * 4c49edbd8df651b1737c59459637962c117212c6 """
See the full comment at https://github.com/SSSD/sssd/pull/233#issuecomment-298605392
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/233 Author: mzidek-rh Title: #233: SDAP: Fix handling of search bases Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/233/head:pr233 git checkout pr233
sssd-devel@lists.fedorahosted.org
-
jhrozek -
lslebodn
-
mzidek-rh