-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/04/2011 08:18 AM, Sumit Bose wrote:
Hi,
based on an issue found by Shanks (#757) I had a closer look at some
parts of the enumeration code in the nss responder and found a different
issue (#758) and some non functional code.
0001: should fix #758.
Ack
0002: should fix #757. If only the local provider was configured the
code did not return to the main loop during execution and the callback
of the corresponding tevent request was never called.I think this is a
regression from the introduction of the synchronous sysdb interface. To
fix it I added a timer event which just calls *_step() again to make
sure we always return to the main loop at least once. Of someone knows
of a more elegant solution I'm all ears. Btw. the code cries for
refactoring.
We have a convention we use in other similar cases. Instead of creating
a new event, just change the return values from nss_cmd_set*ent_step()
to use EOK for "return with immediate post" and to EAGAIN for "return
and re-enter mainloop"
0003: the code arround last_user_enum and last_group_enum was not
functional anymore and the enumeration timeout is handled by
*_result_timeout().
Ack
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk0jU/EACgkQeiVVYja6o6NYZgCffKDXINpPAAwYbtHC1GkqtmSV
NJ0An0Laf5iiFiYJdpVoLBAZ9YC45Oi9
=UQ6q
-----END PGP SIGNATURE-----