[sssd PR#990][opened] ci: keep system list outside repository
by pbrezina
URL: https://github.com/SSSD/sssd/pull/990
Author: pbrezina
Title: #990: ci: keep system list outside repository
Action: opened
PR body:
"""
This way we do not need to push new commit to repository every time
when we change the list of distribution we test on and changes
will be immediately picked up by opened pull request without the
need to rebase them.
It will also help us to temporarily disable particular distribution
when there are errors that we can not fix (e.g. current rawhide issue)
so we can still have all green results.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/990/head:pr990
git checkout pr990
4 years, 1 month
[sssd PR#995][opened] nss: Collision with external nss symbol
by mzidek-gh
URL: https://github.com/SSSD/sssd/pull/995
Author: mzidek-gh
Title: #995: nss: Collision with external nss symbol
Action: opened
PR body:
"""
One of our internal static function names started
to collide with external nss symbol. Additional
sss_ suffix was added to avoid the collision.
This is needed to unblock Fedora Rawhide's
SSSD build.
FYI here is the error on rawhide:
```
src/responder/nss/nss_cmd.c:736:16: error: 'nss_setnetgrent' redeclared as different kind of symbol
736 | static errno_t nss_setnetgrent(struct cli_ctx *cli_ctx,
| ^~~~~~~~~~~~~~~
In file included from ./src/sss_client/sss_cli.h:28,
from ./src/db/sysdb.h:27,
from src/responder/nss/nss_cmd.c:26:
/usr/include/nss.h:184:25: note: previous declaration of 'nss_setnetgrent' was here
184 | typedef enum nss_status nss_setnetgrent (const char *, struct __netgrent *);
| ^~~~~~~~~~~~~~~
```
Running scratch build right now to see if it fixed the issue.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/995/head:pr995
git checkout pr995
4 years, 1 month
[sssd PR#918][comment] Add support for NSS hosts database lookup.
by sumit-bose
URL: https://github.com/SSSD/sssd/pull/918
Title: #918: Add support for NSS hosts database lookup.
sumit-bose commented:
"""
Hi,
thank you for your patience.
The inline comments are Coverity and Clang finding.
Additionally please remve the vim tags
```
$ git grep 'vim:' ../
../src/db/sysdb_iphosts.c:/* vim: set expandtab ts=4 sw=4: */
../src/db/sysdb_iphosts.h:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ad/ad_resolver.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ad/ad_resolver.h:/* vim: set expandtab ts=4 sw=4: */
../src/providers/data_provider/dp_target_resolver.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ldap/ldap_resolver_cleanup.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ldap/ldap_resolver_enum.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ldap/ldap_resolver_enum.h:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ldap/sdap_async_iphost.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ldap/sdap_async_resolver_enum.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ldap/sdap_async_resolver_enum.h:/* vim: set expandtab ts=4 sw=4: */
../src/providers/ldap/sdap_iphost.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/proxy/proxy_hosts.c:/* vim: set expandtab ts=4 sw=4: */
../src/providers/proxy/proxy_init.c:/* vim: set expandtab ts=4 sw=4: */
../src/responder/common/cache_req/plugins/cache_req_enum_ip_hosts.c:/* vim: set expandtab ts=4 sw=4: */
../src/responder/common/cache_req/plugins/cache_req_ip_host_by_addr.c:/* vim: set expandtab ts=4 sw=4: */
../src/responder/common/cache_req/plugins/cache_req_ip_host_by_name.c:/* vim: set expandtab ts=4 sw=4: */
../src/sss_client/nss_hosts.c:/* vim: set expandtab ts=4 sw=4: */
```
Please add the new `ldap_iphost_*` options to `src/config/SSSDConfig/sssdoptions.py`, `src/config/cfg_rules.ini`, `src/config/etc/sssd.api.d/sssd-{ad|ipa|ldap}.conf` to make the config checker and the python config API aware of them.
I tested the patches in different setup and the tests worked well.
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-591019138
4 years, 2 months
Re: KCM notifications
by Simo Sorce
On Mon, 2020-02-24 at 16:08 +0100, Debarshi Ray wrote:
> Hey,
>
> On Fri, Feb 21, 2020 at 7:26 PM Robbie Harwood <rharwood(a)redhat.com> wrote:
> > CCing some GOA folks. I believe their preference was for the inotify
> > approach.
> >
> > Moreover, I'd like to provide a consistent interface to all of the
> > ccaches from krb5. I'm not going to be able to do that if dbus becomes
> > involved (for a variety of reasons).
>
> The GOA code monitoring Kerberos credentials caches is already custom
> made for each different cache type.
>
> So far it has only been inotify for FILE and DIR caches, but we are
> currently working on adding notification support for KEYRING caches
> based on David Howell's ongoing kernel work. See:
> https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/merge_requests/47
I am worried it will take longer still:
https://lkml.org/lkml/2020/1/15/1030
BNu twho knows, Linus can change mind quickly.
> I don't particularly expect D-Bus signals for KCM caches. If it's
> D-Bus, then we will add another code path for KCM, if it's something
> else, we will try to fit it in as best as we can.
>
> Of course, a unified libkrb5 API would be really nice.
My personal comments were going in this direction, however I do not
have a strong preference and if there is consistent investment that we
want to preserve I won't complain.
Simo.
--
Simo Sorce
RHEL Crypto Team
Red Hat, Inc
4 years, 2 months