Thanks, Dennis! (There's a "artifcats" type in the commit.)
I updated my PR's to include the sign-offs.
- Owen
----- Original Message -----
> El mar, 07-03-2017 a las 19:10 -0500, Josh Boyer escribió:
> > On Tue, Mar 7, 2017 at 5:33 PM, Dennis Gilmore <dennis(a)ausil.us>
> > wrote:
> > > El mar, 07-03-2017 a las 14:08 -0500, Owen Taylor escribió:
> > > > On Tue, 2017-03-07 at 13:24 -0500, Owen Taylor wrote:
> > > >
> > > > > > I am just asking you to work with us, pay attention and fix
> > > > > > the
> > > > > > things that have been failing for months with no one
looking
> > > > > > at
> > > > > > it.
> > > > > > Step one is getting it built once a day, because that does
> > > > > > not
> > > > > > happen
> > > > > > and has not in ages.
> > > > >
> > > > > I'm sorry it's been sitting there broken for so long.
Certainly
> > > > > more
> > > > > people following the builds and more people trying out the
> > > > > result
> > > > > is
> > > > > really important, and we'll work towards that. The problem
that
> > > > > it
> > > > > has been hitting was already fixed for Atomic Host, so I'll
> > > > > work on
> > > > > a
> > > > > pull-request to copy those changes over.
> > > >
> > > > I believe:
> > > >
> > > >
https://pagure.io/fedora-lorax-templates/pull-request/13
> > > >
https://pagure.io/fedora-lorax-templates/pull-request/14
> > > >
> > > > should get things working again, though it's not something I
> > > > could
> > > > easily test locally. As noted in the PR, matching changes to how
> > > > lorax
> > > > is invoked are needed.
> > > >
> > > > - Owen
> > >
> > > I can not merge the requests as the commits are not signed off on
> >
> > That project has no indication that commits must be signed off. The
> > only thing there to suggest it would be previous commits. However,
> > the Signed-off-by in those previous commit logs is literally
> > meaningless because there is nothing in the code base that describes
> > what it means. You're just following a convention at this point, and
> > how is a developer supposed to know what he or she is signing off on?
> >
> > If the intention is to be using the DCO
> > (
https://developercertificate.org/) then put that in the README.md
> > file, or COPYING, or something to at least give contributors some
> > idea
> > what the hell is going on.
>
> I have submitted a pull request updating the README.md
>
https://pagure.io/fedora-lorax-templates/pull-request/15 there was
> never a intention to be vague. It was a oversight when we moved things
> to pagure. all of the release engineering controlled repos require
> commits to be signed off on in order to be using DCO
>
> Dennis
> _______________________________________________
> desktop mailing list -- desktop(a)lists.fedoraproject.org
> To unsubscribe send an email to desktop-leave(a)lists.fedoraproject.org
>